Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2

Open
wants to merge 1 commit into
base: add-ssa-cleaner
Choose a base branch
from
Open

Fix #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 8 additions & 71 deletions cmd/ssa-cleaner/cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,16 +135,6 @@ var rootCmd = &cobra.Command{
if err != nil {
return err
}

err = manageAllFields(ctx, res)
if err != nil {
return err
}

err = releaseAllFields(ctx, res)
if err != nil {
return err
}
}

return nil
Expand Down Expand Up @@ -237,76 +227,23 @@ func removeBeforeFirstApply(ctx context.Context, res cke.ResourceDefinition) err
if err != nil {
return fmt.Errorf("failed to get object for %s: %w", res.Key, err)
}

index := -1
for i, f := range obj.Current.GetManagedFields() {
if f.Manager == managerBeforeFirstApply && f.Operation == metav1.ManagedFieldsOperationUpdate {
index = i
break
}
}
if index == -1 {
return nil
}

log.Info("remove before-first-apply manager", map[string]interface{}{
"key": res.Key,
})
patch := fmt.Sprintf(`[{"op": "remove", "path": "/metadata/managedFields/%d"}]`, index)
if _, err := obj.Resource.Patch(ctx, obj.Current.GetName(), types.JSONPatchType, []byte(patch), metav1.PatchOptions{}); err != nil {
log.Error("failed to patch", map[string]interface{}{
"key": res.Key,
log.FnError: err,
})
return err
}

return nil
}

func manageAllFields(ctx context.Context, res cke.ResourceDefinition) error {
obj, err := getObject(ctx, res)
if err != nil {
return fmt.Errorf("failed to get object for %s: %w", res.Key, err)
}

new := obj.Current.DeepCopy()
unstructured.RemoveNestedField(new.Object, "metadata", "managedFields")
unstructured.RemoveNestedField(new.Object, "status")

log.Info("manage all fields", map[string]interface{}{
"key": res.Key,
})
// apply current resource without change as Cleaner
if err := obj.Apply(ctx, new, managerCleaner, false); err != nil {
log.Error("failed to apply", map[string]interface{}{
"key": res.Key,
log.FnError: err,
})
return err
}

return nil
}

func releaseAllFields(ctx context.Context, res cke.ResourceDefinition) error {
obj, err := getObject(ctx, res)
if err != nil {
return fmt.Errorf("failed to get object for %s: %w", res.Key, err)
var managedFields []metav1.ManagedFieldsEntry
for _, f := range new.GetManagedFields() {
if f.Manager != managerBeforeFirstApply {
managedFields = append(managedFields, f)
}
}
new.SetManagedFields(managedFields)

new := &unstructured.Unstructured{}
new.SetAPIVersion(obj.Current.GetAPIVersion())
new.SetKind(obj.Current.GetKind())
new.SetNamespace(obj.Current.GetNamespace())
new.SetName(obj.Current.GetName())

log.Info("release all fields", map[string]interface{}{
"key": res.Key,
})
// apply empty resource as Cleaner
if err := obj.Apply(ctx, new, managerCleaner, false); err != nil {
log.Error("failed to apply", map[string]interface{}{
if _, err := obj.Resource.Update(ctx, new, metav1.UpdateOptions{}); err != nil {
log.Error("failed to patch", map[string]interface{}{
"key": res.Key,
log.FnError: err,
})
Expand Down