Reordered code execution #516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoveGroupInterface was moved before spinning up the executor. Reordered code execution JointModelGroup was moved before spinning up the executor. Also explained what the executor does. Reordered code execution JointModelGroup was moved before spinning up the executor. Also explained what the executor does. Fix minor build error, formatting
|
Are there other files that need to be modified before we merge the branch? I haven't been through the entire docs to confirm any other cases, but so far this is it. |
|
We are only waiting on CI to pass. It's nothing related to this PR. Sorry for the delay |
|
I think the correct fix for this is to enable Cyclone DDS, which is addressed in #519. So I vote to close this PR. |
|
@AndyZe should we go ahead and close this, since the fix is enabling cyclone DDS which is mentioned in the tutorials? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm specifically talking about this issue: moveit/moveit2#1474. I only changed the order in which code is executed by creating the MoveGroup Interface before the executor.
The format of the code was not changed. The text explaining what the code does was also changed to represent the newly added/removed lines.
Takes over from PR #514