Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ompl_planning.yaml file #111

Open
wants to merge 3 commits into
base: melodic-devel
Choose a base branch
from

Conversation

jesseli2002
Copy link

Ran the Moveit setup assistant, which basically rewrote the entire file. I've checked that demo.launch still works, but I'm not sure if there's something else I should verify as well.

Copy link

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adapt the projection_evaluators for all planning groups.

- KPIECEkConfigDefault
- BKPIECEkConfigDefault
- RRTStarkConfigDefault
projection_evaluator: link(r_wrist_roll_link)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the projection_evaluator for each planning group.

- LazyPRMstar
- SPARS
- SPARStwo
projection_evaluator: joints(r_shoulder_pan_joint,r_shoulder_lift_joint)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... which is changed here.

@jesseli2002
Copy link
Author

I've gone through and checked that the projection_evaluators for the previous version have been kept where given. I've also changed the arms_and_torso projection_evaluator from the default of joints(torso_lift_joint,l_shoulder_pan_joint) to joints(r_shoulder_pan_joint,l_shoulder_pan_joint), which is the same as the evaluator for whole_body.

Although - I've noticed that the projection_evaluator for the right and left arm groups aren't symmetric - as you've mentioned right_arm was previously link(r_wrist_roll_link) but left_arm is joints(l_shoulder_pan_joint,l_shoulder_lift_joint) - is there a good reason for this asymmetry?

@jesseli2002 jesseli2002 requested a review from rhaschke May 27, 2020 19:40
@v4hn
Copy link
Contributor

v4hn commented May 27, 2020 via email

@jesseli2002
Copy link
Author

The whole PR2 configuration grew historically and probably contains some experimental changes too. Personally, I would consider generating a new one from scratch and replace the contents of this repository entirely to use MoveIt with a PR2 (and indeed this is what I do with a modified PR2 over here anyway). Thus, I'm actually somewhat lost with how to handle proposed local modifications to this repository...

That's what I've done in my work too. But replacing everything using the setup assistant doesn't work out of the box - I wasn't able to use demo.launch when it overwrites launch/pr2_moveit_controller_manager.launch.xml, and that file mentions a few plugin-specific parameters. A cursory search shows up other files that say they have plugin-specific values, but I guess they fail in quieter ways. I also believe the SRDF self-collision pairs were generated with the KINECT1 xacro arg set.

I think it'd be a good idea to replace everything that doesn't explicitly mention plugin-specific parameters for now, and I was planning to put in a sequence of pull requests to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants