-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ompl_planning.yaml file #111
base: melodic-devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adapt the projection_evaluators for all planning groups.
- KPIECEkConfigDefault | ||
- BKPIECEkConfigDefault | ||
- RRTStarkConfigDefault | ||
projection_evaluator: link(r_wrist_roll_link) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the projection_evaluator for each planning group.
- LazyPRMstar | ||
- SPARS | ||
- SPARStwo | ||
projection_evaluator: joints(r_shoulder_pan_joint,r_shoulder_lift_joint) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... which is changed here.
I've gone through and checked that the Although - I've noticed that the |
The whole PR2 configuration grew historically and probably contains some experimental changes too.
Personally, I would consider generating a new one from scratch and replace the contents of this repository entirely to use MoveIt with a PR2 (and indeed this is what I do with a modified PR2 over here anyway). Thus, I'm actually somewhat lost with how to handle proposed local modifications to this repository...
|
That's what I've done in my work too. But replacing everything using the setup assistant doesn't work out of the box - I wasn't able to use demo.launch when it overwrites I think it'd be a good idea to replace everything that doesn't explicitly mention plugin-specific parameters for now, and I was planning to put in a sequence of pull requests to do that. |
Ran the Moveit setup assistant, which basically rewrote the entire file. I've checked that
demo.launch
still works, but I'm not sure if there's something else I should verify as well.