Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare to release version 3.4. Helps to fix Issue #95. #97

Closed
wants to merge 6 commits into from
Closed

Prepare to release version 3.4. Helps to fix Issue #95. #97

wants to merge 6 commits into from

Conversation

xabolcs
Copy link
Collaborator

@xabolcs xabolcs commented Oct 11, 2012

Hi!

Please do not stash the 3.5pre version bump commit with the others!
Merge this pull request as 2 commit: one for the release notes and one for version bump.

There should be a commit where the <version> is 3.4 in install.rdf!
That commit should be tagged as v3.4!

Release Notes contains:

Nice to have (but not blocking!) fixes (in priority order):

Please note that the issue numbers in the commit are the issue numbers instead pull numbers!

AMO Release Notes strings:

Built from <a href="https://github.com/mozilla/nightlytt/commit/99f1679e01fc"><code>99f1679e01fc</code></a>.
<ul>
  <li>Extension: Use GreD instead CurProcD to reference GRE specific files. (<a href="https://github.com/mozilla/nightlytt/issues/115">#115</a>)</li>
  <li>Extension: Update checkCompatibility preferences for compatibility. (<a href="https://github.com/mozilla/nightlytt/issues/103">#103</a>)</li>
  <li>Extension: Add privacy context to <code>saveScreenshot()</code> due to <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=795065">Bug 795065</a>. (<a href="https://github.com/mozilla/nightlytt/issues/99">#99</a>)</li>
  <li>Extension: Make columns of 'Customize Titlebar' dialog's tree resizable. (<a href="https://github.com/mozilla/nightlytt/issues/25">#25</a>)</li>
  <li>Extension: Re-license under MPL2. (<a href="https://github.com/mozilla/nightlytt/issues/39">#39</a>, <a href="https://github.com/mozilla/nightlytt/issues/98">#98</a>)</li>
  <li>Extension: Update 'Contributors' section automatically in about:nightly. (<a href="https://github.com/mozilla/nightlytt/issues/58">#58</a>)</li>
  <li>Extension: Don't register aboutNightly component for 'profile-after-change' notification. (<a href="https://github.com/mozilla/nightlytt/issues/57">#57</a>)</li>
  <li>Extension: Don't call callback function when iterating over Extension Manager's extensions list. (<a href="https://github.com/mozilla/nightlytt/issues/88">#88</a>)</li>
  <li>Extension: Include about:nightly in Nightly Tester Tools' menupopup for Thunderbird. (<a href="https://github.com/mozilla/nightlytt/issues/56">#56</a>)</li>
  <li>Extension: Let <code>nightlyApp.openNotification()</code> fallback to notificationBox in legacy Fx. (<a href="https://github.com/mozilla/nightlytt/issues/81">#81</a>)</li>
  <li>Extension: Open customize.xul (Customize Titlebar)</li> as a resizable window. (<a href="https://github.com/mozilla/nightlytt/issues/55">#55</a>)</li>
  <li>Extension: Add pushlog-to-tip menuitem. (<a href="https://github.com/mozilla/nightlytt/issues/61">#61</a>)</li>
  <li>Extension: Include changeset info in the Insert/Copy Build ID menuitem and in 'Customize Titlebar'. (<a href="https://github.com/mozilla/nightlytt/issues/65">#65</a>)</li>
</ul>

Details are on <a href="https://github.com/mozilla/nightlytt/compare/v3.3...v3.4">GitHub</a>.

@whimboo
Copy link
Contributor

whimboo commented Oct 17, 2012

Please remove the commit for the 3.5pre version bump. That will be done separately and is not part of this task.

whimboo
whimboo reviewed Oct 17, 2012
View reviewed changes
History.md
3.4 / 2012-10-11
==================

* Extension: Include changeset info in the Insert/Copy Build ID menuitem and in 'Customize Titlebar'. (#65)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the pull # instead of the issue #. Reason is that we have to be consistent and check-ins will have a pull but not necessarily an issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote for __Issue Number__s, because they are more descriptive, they are the goal, the drivers of development.
Pulls are tools of controlling - how the changes are accepted and merged into source.

Of course Pull Number is OK, when no Issue Number exists.

Other way of reasoning:
Pulls are closer to compare view (e.g. v3.2.2...v3.3), and issues are closer to milestones.
And release notes (history.md) are closer to milestones, IMHO.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For another example see mozmill!

It's official repository is on GitHub, but it's tracker is bugzilla.mozilla.org.
Check the it's changelists on AMO, it uses bug numbers instead of pull numbers!
(The commit messages refers to bug numbers also - but this is not the subject here)

As I noted in my previous comment, the issue numbers are more informative than the pull request numbers.

@xabolcs
Copy link
Collaborator Author

xabolcs commented Oct 18, 2012

If 3.4 going to be released without the Force compatibility enhancement (Issue #52 / Pull #82) then a version-string update to nttAddonCompatibilityService.js is really recommended!

@xabolcs
Copy link
Collaborator Author

xabolcs commented Oct 18, 2012

Updated description due to landings:

@xabolcs
Copy link
Collaborator Author

xabolcs commented Oct 19, 2012

Updated description due to removed commit 0a16d69:

  • deleted no stash please

@xabolcs
Issue mozilla#95 - update part 1:
7260099 
- MPL 2 landed
- column resize landed
@xabolcs
Copy link
Collaborator Author

xabolcs commented Oct 25, 2012

Updated commit range (including 7260099):

  • history.md updates

Still using Issue Numbers because @whimboo didn't give a feedback to my comments.

@xabolcs
Copy link
Collaborator Author

xabolcs commented Oct 25, 2012

xabolcs commented:

If 3.4 going to be released without the Force compatibility enhancement (Issue #52 / Pull #82) then a version-string update to nttAddonCompatibilityService.js is really recommended!

Opened Pull #103.

@xabolcs
Copy link
Collaborator Author

xabolcs commented Oct 25, 2012

Updated description:

  • removed xpis - they are now outdated

@xabolcs
Issue mozilla#95 - update part 2:
7033509 
- privacyContext'ed screenshot landed
@xabolcs
Copy link
Collaborator Author

xabolcs commented Oct 26, 2012

Updated description & commit range due to landings:

@xabolcs
Copy link
Collaborator Author

xabolcs commented Oct 30, 2012

Should I provide here (for example in the description) AMO formatted Release Notes to avoid Markdown formatted strings being used on AMO?

@tonymec
Copy link
Contributor

tonymec commented Oct 31, 2012

IIUC one pull may refer to zero, one, two… issues. I agree that the issue number(s) are more meaningful than the pull number (on hg.mozilla.org, each commit has either a bug number or NO BUG) but why not mention the pull number and also all the issues it fixes (or helps to fix)?

@xabolcs
Copy link
Collaborator Author

xabolcs commented Oct 31, 2012

I agree with tonymec.

tonymec wrote:

... but why not mention the pull number and also all the issues it fixes (or helps to fix)?

For example see my comment on mozillaZine:

The extras are:

Another example is the desctiption:

Release Notes contains:

@xabolcs
Issue mozilla#95 - update part 3:
99f1679 
- 'extensions.checkCompatibility' updated
@xabolcs
Copy link
Collaborator Author

xabolcs commented Nov 3, 2012

Updated description & commit range due to landing:

@whimboo
Copy link
Contributor

whimboo commented Nov 6, 2012

Ok, we further discussed this and @davehunt also agrees on using the issue # instead. @xabolcs would you mind to update the pull and replace all # with the issue #?

@xabolcs
Copy link
Collaborator Author

xabolcs commented Nov 6, 2012

Thanks!

Currently almost all the numbers are issue #. Only titlebar.css MPL2 (#98, related to issue #39) and checkCompatibility bump (#103, related to release work, issue #95) are pull #, because there was no needed to open a separate issue for them.

Also the AMO strings are using issue #s (where exists, and the issue -> pull redirect does work).

I think the pull request is up to date in the term of numbers.
And it's based on commit 788d3fce7015.
(Of course update will be necessary if other fixes land. :) )

Should I do other changes or checks?

@whimboo
Copy link
Contributor

whimboo commented Nov 6, 2012

Given that you have the best overview of pull requests at the moment it would be good to know which ones you would like to see in 3.4. How many remain before we can release the next version?

@xabolcs
Copy link
Collaborator Author

xabolcs commented Nov 6, 2012

Nice to have pulls:

@xabolcs
Copy link
Collaborator Author

xabolcs commented Jan 30, 2013

@whimboo
Do you allow me to merge this pull, pack NTT 3.4 in it's current state into xpi
and ask somebody (@tonymec? :)) to upload that file to AMO?
Do you agree with the above?

Please drop a line!

@whimboo
Copy link
Contributor

whimboo commented Feb 18, 2013

Sorry for the late reply but I was on vacation for a while. So with the latest fix from #115 landed we should get out a new version of NTT as soon as possible. Would you mind to update this pull so we can get this version released?

@xabolcs
Issue mozilla#95 - update part 4:
892eaf4 
- GreD/CurProcD workaround for Bug 755724
@xabolcs
Copy link
Collaborator Author

xabolcs commented Feb 18, 2013

@whimboo

Just updated the commit range to include the updated changelist + release date.
I updated the AMO Release Notes strings section in the description of this pull. Feel free to use that on AMO!

Let 3.4 go! :)

whimboo
whimboo reviewed Feb 19, 2013
View reviewed changes
History.md
* Extension: Make columns of 'Customize Titlebar' dialog's tree resizable. (#25)
* Extension: Add privacy context to saveScreenshot() due to Bug 795065. (#99)
* Extension: Update checkCompatibility preferences for compatibility. (#103)
* Extension: Use GreD instead CurProcD to reference GRE specific files. (#115)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of the items look incorrect. We usually sort descending with the most recent fix at the top. Can you please fix that?

@xabolcs
Issue mozilla#95 - update part 5:
1468566 
- reverse changelist
- maxVersion
@xabolcs
Copy link
Collaborator Author

xabolcs commented Feb 19, 2013

@whimboo
Updated commit range, updated description (for AMO strings)

@whimboo
Copy link
Contributor

whimboo commented Feb 19, 2013

6f745ba

@whimboo whimboo closed this Feb 19, 2013
@xabolcs xabolcs deleted the branch-issue-95-release-ntt-version-3.4 branch February 19, 2013 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xabolcs @whimboo @tonymec