Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to release version 3.4. Helps to fix Issue #95. #97

Closed
wants to merge 6 commits into from
Closed

Prepare to release version 3.4. Helps to fix Issue #95. #97

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ac3219
Issue #95 - prepare versions and changelog for 3.4 release
xabolcs Oct 11, 2012
7260099
Issue #95 - update part 1:
xabolcs Oct 25, 2012
7033509
Issue #95 - update part 2:
xabolcs Oct 26, 2012
99f1679
Issue #95 - update part 3:
xabolcs Nov 3, 2012
892eaf4
Issue #95 - update part 4:
xabolcs Feb 18, 2013
1468566
Issue #95 - update part 5:
xabolcs Feb 19, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions History.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
3.4 / 2013-02-18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump the date for today?

==================

* Extension: Include changeset info in the Insert/Copy Build ID menuitem and in 'Customize Titlebar'. (#65)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the pull # instead of the issue #. Reason is that we have to be consistent and check-ins will have a pull but not necessarily an issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote for __Issue Number__s, because they are more descriptive, they are the goal, the drivers of development.
Pulls are tools of controlling - how the changes are accepted and merged into source.

Of course Pull Number is OK, when no Issue Number exists.

Other way of reasoning:
Pulls are closer to compare view (e.g. v3.2.2...v3.3), and issues are closer to milestones.
And release notes (history.md) are closer to milestones, IMHO.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For another example see mozmill!

It's official repository is on GitHub, but it's tracker is bugzilla.mozilla.org.
Check the it's changelists on AMO, it uses bug numbers instead of pull numbers!
(The commit messages refers to bug numbers also - but this is not the subject here)

As I noted in my previous comment, the issue numbers are more informative than the pull request numbers.

* Extension: Add pushlog-to-tip menuitem. (#61)
* Extension: Open customize.xul (Customize Titlebar) as a resizable window. (#55)
* Extension: Let nightlyApp.openNotification() fallback to notificationBox in legacy Fx. (#81)
* Extension: Include about:nightly in Nightly Tester Tools' menupopup for Thunderbird. (#56)
* Extension: Don't call callback function when iterating over Extension Manager's extensions list. (#88)
* Extension: Don't register aboutNightly component for 'profile-after-change' notification. (#57)
* Extension: Update 'Contributors' section automatically in about:nightly. (#58)
* Extension: Re-license under MPL2. (#39, #98)
* Extension: Make columns of 'Customize Titlebar' dialog's tree resizable. (#25)
* Extension: Add privacy context to saveScreenshot() due to Bug 795065. (#99)
* Extension: Update checkCompatibility preferences for compatibility. (#103)
* Extension: Use GreD instead CurProcD to reference GRE specific files. (#115)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of the items look incorrect. We usually sort descending with the most recent fix at the top. Can you please fix that?


3.3 / 2012-05-02
==================

Expand Down
10 changes: 5 additions & 5 deletions extension/install.rdf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<Description about="urn:mozilla:install-manifest">
<em:id>{8620c15f-30dc-4dba-a131-7c5d20cf4a29}</em:id>
<em:version>3.4pre</em:version>
<em:version>3.4</em:version>
<em:type>2</em:type>

<!-- Need unpacking for crashme binary components -->
Expand Down Expand Up @@ -36,7 +36,7 @@
<Description>
<em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
<em:minVersion>3.6</em:minVersion>
<em:maxVersion>15.0a1</em:maxVersion>
<em:maxVersion>19.0a1</em:maxVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meanwhile we have 21.0a1. You might want to update the other versions too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fx 22's release date is 2013-02-19. What about updating maxVersion to 22.0a1 instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, please do so. Totally missed that. :)

</Description>
</em:targetApplication>

Expand All @@ -45,7 +45,7 @@
<Description>
<em:id>{3550f703-e582-4d05-9a08-453d09bdfdc6}</em:id>
<em:minVersion>3.1</em:minVersion>
<em:maxVersion>15.0a1</em:maxVersion>
<em:maxVersion>19.0a1</em:maxVersion>
</Description>
</em:targetApplication>

Expand All @@ -54,7 +54,7 @@
<Description>
<em:id>{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}</em:id>
<em:minVersion>2.1a1pre</em:minVersion>
<em:maxVersion>2.12a1</em:maxVersion>
<em:maxVersion>2.16a1</em:maxVersion>
</Description>
</em:targetApplication>

Expand All @@ -63,7 +63,7 @@
<Description>
<em:id>songbird@songbirdnest.com</em:id>
<em:minVersion>1.6</em:minVersion>
<em:maxVersion>1.12.0a</em:maxVersion>
<em:maxVersion>2.2.0a</em:maxVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, a major version change. Do you know on which gecko branch this version is based on?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whimboo wrote:

Oh wow, a major version change. Do you know on which gecko branch this version is based on?

Regarding to application.ini.in and sbBuildInfo.mk.in it is based on Gecko 1.9.2.

[Gecko]
MinVersion=1.9.2
MaxVersion=1.9.2.*

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn. I was really hoping they get off from this gecko branch. :(

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whimboo wrote:

Damn. ...

I happily do the needed extra maintenance work. :)

</Description>
</em:targetApplication>

Expand Down