-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support intl-tel-input 19 #49
Conversation
Thanks for this PR. Looks like the new API is not backward compatible, tests are failing :/ |
Ok i will have a look |
There is the last that fails but i don't know if it's normal or not. For me it's a normal component because there is no translation for Sweden in i18n object and by default intl-tel-input put in english. |
@@ -31,7 +31,7 @@ export class IntlTelInputComponent implements AfterViewInit { | |||
@Output() private E164PhoneNumberChange = new EventEmitter<string | null>(); | |||
@ViewChild('intlTelInput') private _inputElement!: ElementRef; | |||
private _phoneNumber!: string; | |||
private _intlTelInput: any; | |||
public _intlTelInput: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should stay private
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oups my bad was debugging somethink and forget about it ....
@@ -7,7 +7,7 @@ | |||
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | |||
*/ | |||
|
|||
import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing'; | |||
import { ComponentFixture, TestBed } from '@angular/core/testing'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch ! The linter should have warned...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe updating all packages will help
Thanks, I have checkout locally the PR. The jackocnr/intl-tel-input@03277c4 (watch diff for data.js) |
I remove the test as you said :) |
Thanks, But this should be removed too (and readme should be updated because this option is removed) :
|
Good job. Will review and polish ASAP, before the end of the week in any case. Will need to squash your commits. I hadn't seen you had forked and committed to master, so will have to do this locally, because I think i won't be able to push/force push to your master :/ (not a big deal anyway) Thanks a lot for this contribution! |
v0.11.0 has been released. Thanks for contributing! |
Hi
This PR upgrade intl-tel-input to version 19. (Don't think we need to touch at somethink else).
Thanks for the work on this libary :)