-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support intl-tel-input 19 #49
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,7 +31,7 @@ export class IntlTelInputComponent implements AfterViewInit { | |
@Output() private E164PhoneNumberChange = new EventEmitter<string | null>(); | ||
@ViewChild('intlTelInput') private _inputElement!: ElementRef; | ||
private _phoneNumber!: string; | ||
private _intlTelInput: any; | ||
public _intlTelInput: any; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should stay private There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oups my bad was debugging somethink and forget about it .... |
||
|
||
private static modifyCountryData(): void { | ||
(window as any).intlTelInputGlobals.getCountryData().forEach((country: CountryData) => | ||
|
@@ -65,7 +65,7 @@ export class IntlTelInputComponent implements AfterViewInit { | |
|
||
i18nizePhoneNumber(): void { | ||
this.E164PhoneNumber = null; | ||
if (this._intlTelInput.isValidNumber()) { | ||
if (this._intlTelInput.isValidNumberPrecise()) { | ||
this.E164PhoneNumber = this._intlTelInput.getNumber(); | ||
} | ||
this.E164PhoneNumberChange.emit(this.E164PhoneNumber); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch ! The linter should have warned...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe updating all packages will help