Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up rng functions, towards a real interface #118

Merged
merged 15 commits into from
Dec 3, 2024
Merged

Tidy up rng functions, towards a real interface #118

merged 15 commits into from
Dec 3, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Nov 29, 2024

Merge after #117, contains those commits

This PR starts building a free-function interface to the RNG, covering a few distributions (the ones used in the SIR helper only). The main source of pain is thinking about how to cope with the multiple-draw case vs single draw case, which I have done with a separate function for each

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (2b46639) to head (53839b8).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   99.57%   99.59%   +0.02%     
==========================================
  Files          73       73              
  Lines        5582     5711     +129     
==========================================
+ Hits         5558     5688     +130     
+ Misses         24       23       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richfitz richfitz marked this pull request as ready for review December 2, 2024 09:05
@richfitz richfitz requested a review from weshinsley December 2, 2024 09:24
@richfitz richfitz merged commit 7e2ae12 into main Dec 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants