mrc-5970 lint, codecov and other friends

[M-Kusumgar]

main changes:

• the npm package codecov is actually deprecated which explains a lot of the flakiness and problems, the recommendation is to use the github action which is what i have switch to here
• i have added a coverage command configured with istanbul provider
• set vitest to silent, vuex and vue warnings are very annoying in the buildkite stream
• removed check formatting for now, this is for a later time when we have a discussion about eslint rules and prettier formatting and what we want to move forward with, so i have also not included a lot of eslint rules from our original wodin file either, i think the defaults right now are actually stricter anyway

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (mrc-5967@3f9f497). Learn more about missing BASE report.

Additional details and impacted files

@@             Coverage Diff             @@
##             mrc-5967     #230   +/-   ##
===========================================
  Coverage            ?   99.78%           
===========================================
  Files               ?      160           
  Lines               ?     4110           
  Branches            ?      939           
===========================================
  Hits                ?     4101           
  Misses              ?        8           
  Partials            ?        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[EmmaLRussell]

I don't know if you're planning on reinstating the eslint rules, but rather than removing some valid exceptions here, I think it might be better to just retain some rules which it seems are now switched off.

Specifically it feels like it would be good to retain the following to keep us tidy:

• no-explicit-any
• no-unused-vars
• no-setup-props-destructure

Not especially bothered about this others personally!

[EmmaLRussell]

Coverage changes look great, good to deflakify that! 😆

[M-Kusumgar]

have switched on the rules, i was planning to discuss the rules in more detail with you and anmol and prettier in this ticket https://mrc-ide.myjetbrains.com/youtrack/issue/mrc-5973/eslint-and-prettier-discussion-ticket but have added those three rules as they seem uncontroversial (although no-setup-props-destructure is something we do a lot and i may lean towards not having that rule but happy to put it in right now)

i also went on a mission to rid the codebase of all the anys, felt great but also discovered a bug! we were using object.details instead of object.detail in isApiError so also fixed some tests related to it and fixed the code

[EmmaLRussell]

Great, thanks!