Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrc-5970 lint, codecov and other friends #230

Merged
merged 17 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
with:
node-version: 20.x
- name: Install dependencies
run: npm install -g typescript codecov
run: npm install -g typescript
- name: Build
run: ./scripts/build.sh
- name: Run dependencies
Expand All @@ -21,16 +21,15 @@ jobs:
- name: Test back end integration
run: npm run integration-test --prefix=app/server
- name: Test front end
run: npm run test:unit --prefix=app/static
run: npm run coverage --prefix=app/static
- name: Lint back end
run: npm run lint --prefix=app/server
- name: Lint front end
run: npm run lint --prefix=app/static
- name: Check formatting frontend
run: npm run format:check --prefix=app/static
- name: Check versions
run: npm run genversion --prefix=app/server -- --check-only
- name: Upload coverage
run: |
codecov -f app/static/coverage/*.json
codecov -f app/server/coverage/*.json
- uses: codecov/codecov-action@v4
with:
fail_ci_if_error: true # optional (default = false)
files: ./app/server/coverage/coverage-final.json,./app/static/coverage/coverage-final.json
token: ${{ secrets.CODECOV_TOKEN }} # required
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
/app/server/coverage/
/app/server/node_modules/
/app/server/public/
!/app/server/public/favicon.ico
/app/server/dist/
/app/static/node_modules/
/app/static/coverage/
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16
v20
File renamed without changes.
9 changes: 6 additions & 3 deletions app/static/eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,19 @@ export default [
},

{
files: ["**/*.ts", "**/*.vue"],
files: ["src/**/*.ts", "src/**/*.vue"],
rules: {
"@typescript-eslint/no-explicit-any": "off"
"@typescript-eslint/no-explicit-any": "error",
"@typescript-eslint/no-unused-vars": "error",
"vue/no-setup-props-destructure": "error",
}
},

{
files: ["**/tests/**/*.ts"],
rules: {
"vitest/expect-expect": "off"
"vitest/expect-expect": "off",
"@typescript-eslint/no-explicit-any": "off",
}
},

Expand Down
Loading
Loading