Don't allow undefined in Address constructor #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix iframe creation
Merge development into main
Merge development into main
Merge development into main
Currently this code is allowed: ``` new Address(undefined); ``` But this code doesn't make sense and is bug-prone. I discovered several bugs in my code because I passed `undefined` to `Address` constructor.
|
Hi @lcswillems, Currently, we use Thanks 🙏 |
|
Hi @andreibancioiu, You can do as you wish. This is not my lib. If I opened this PR, it is because I believe it is not a good practice to allow undefined. And I don't get in which case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this code is allowed:
But this code doesn't make sense and is bug-prone. I discovered several bugs in my code because I passed
undefinedtoAddressconstructor.