Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow undefined in Address constructor #74

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Don't allow undefined in Address constructor #74

wants to merge 5 commits into from

Commits on Aug 12, 2021

  1. Merge pull request #55 from ElrondNetwork/bugfix-iframe-creation 

    Bugfix iframe creation
    @ccorcoveanu
    ccorcoveanu authored Aug 12, 2021
    Configuration menu
    Copy the full SHA
    a50fde6 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Merge pull request #65 from ElrondNetwork/development 

    Merge development into main
    @ccorcoveanu
    ccorcoveanu authored Aug 25, 2021
    Configuration menu
    Copy the full SHA
    f2085cd View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. Merge pull request #68 from ElrondNetwork/development 

    Merge development into main
    @ccorcoveanu
    ccorcoveanu authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    36cb229 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #71 from ElrondNetwork/development 

    Merge development into main
    @ccorcoveanu
    ccorcoveanu authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    f036825 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Don't allow undefined in Address constructor 

    Currently this code is allowed:

```
new Address(undefined);
```

But this code doesn't make sense and is bug-prone. I discovered several bugs in my code because I passed `undefined` to `Address` constructor.
    @lcswillems
    lcswillems authored Sep 22, 2021
    Configuration menu
    Copy the full SHA
    d1fcc11 View commit details
    Browse the repository at this point in the history