Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update duckduckgo_search(fix #490) #501

Closed
wants to merge 1 commit into from
Closed

Conversation

Jipok
Copy link

@Jipok Jipok commented Dec 15, 2023

@CameronJGrant
Copy link

Did you test this?

@Jipok
Copy link
Author

Jipok commented Dec 20, 2023

yes

@CameronJGrant
Copy link

The docker image doesn't build. I've fixed this issue here:
#506

@k3it
Copy link
Contributor

k3it commented Dec 24, 2023

the real issue seems to be that curl_cffi does not build properly on Alpine: lexiforest/curl_cffi#31 and there is no wheel package. switching to python:3.9-bookworm works, but the docker image becomes heavy. I'm not sure if #506 fixes it by adding poetry or with another workarounds related to impersonate cffi build dependency (addressed outside of poetry). curious there is a simpler way to build curl_cffi on alpine..

@CameronJGrant
Copy link

@Jipok Feel free to copy the changes from my PR to yours and I will close mine. It's the same except I add one more dependency and some small Dockerfile additions to do the fixes @k3it mentioned.

Poetry has been dropped. It's a minimal fix now:
619421e

I'm not sure if #506 fixes it by adding poetry or with another workarounds related to impersonate cffi build dependency.

The repo that hosts impersonate-cffi has a Docker image that builds it specifically for alpine. I call that image and copy over the libraries to our image to keep it light weight.

@Jipok
Copy link
Author

Jipok commented Dec 26, 2023

#506

@Jipok Jipok closed this Dec 26, 2023
@perklet
Copy link

perklet commented Mar 6, 2024

the real issue seems to be that curl_cffi does not build properly on Alpine: yifeikong/curl_cffi#31 and there is no wheel package.

curl_cffi maintainer here, just added Alpine support in 0.6.3b1(a beta version), which you can install explicitly by specifying the version. I hope this can resolve your issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants