-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated duckduckgo-search. (Fixes #490) #506
Conversation
Why remove requirements.txt? |
It hasn't been removed. It's been replaced with the "pyproject.toml" file (Poetry https://python-poetry.org/). It works the same except it ensures package versions work together. It also generates a lock file, with hashes for each package, so that your environment is identical to everyone elses. This is especially important when building Dockerfiles. Otherwise we can have a situation where "chatgpt-telegram-bot" works on your system, but not on mine. If you're not familiar with it, check it out. It will help with future projects. |
It was clearly deleted judging by what Github shows.
except that it requires installing poetry. In which I don’t see any point at all for such projects. |
@Jipok has a point. it looks like poetry repo has 612 open issues and 85 pull requests, so it's a highly complex dependency all by itself. |
I've editted this response. I agree with both of your points. This should have been maybe 3 separate PR's. One for the fix. One for the overall updates. And one for the dependency manager. I'll edit this PR when I have time. Otherwise we can take @Jipok's PR and add a Dockerfile fix to it and it will be fine too. |
I've made this simpler now. No more Poetry. |
paging @n3d1117 |
For me, this literally doubled the image size. Ie Dive shows a lot in /usr/lib/. I don't know exactly how to selectively remove the build dependencies. |
Hmm. I did remove the gcc build dependencies in the line It may be a moot point anyway as I've heard nothing from @n3d1117. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now it is
duckduckgo_search~=5.0
curl-cffi~=0.6.3b1
Hi all, sorry for the long wait, are these changes still relevant? Or is it enough to update to latest |
Thanks to @yifeikong for his update of curl_cffi @A1RWALK3R suggestion should do it. |
This fix no longer works. DDG is returning "Failed to get response...202 Ratelimit". |
And by this fix I mean @A1RWALK3R 's suggestion. |
Thanks, @A1RWALK3R . I saw that actually, that fix doesn't work, either. I tried recreating the bot with that version. I'll just be patient till they get it sorted. |
I've updated everything to the latest versions and added poetry as a dependency management system. Note that later versions of "duckduckgo-search" need to use "curl-cffi" and that brought about a host of new issues that needed to be dealt with. That's why there are a so many edits to the Dockerfile.