Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding serialization example #107

Merged
merged 8 commits into from
Oct 13, 2023
Merged

Adding serialization example #107

merged 8 commits into from
Oct 13, 2023

Conversation

kjjarvis
Copy link
Contributor

@kjjarvis kjjarvis commented Oct 11, 2023

Adding serialization example to 04. New Models; including conclusion for entire New Models example.

Also deleted the default process_noise defined as 1e-03 in the BatteryElectroChemEOD model. Since this was first defined, we have added a default process_noise of 0 for all prognostics models, so this was outdated.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #107 (cb27026) into dev (ac51178) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #107   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files         100      100           
  Lines       10281    10281           
=======================================
  Hits         8589     8589           
  Misses       1692     1692           
Files Coverage Δ
src/progpy/models/battery_electrochem.py 79.16% <ø> (ø)

Copy link
Contributor

@teubert teubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good- a few suggestions.

Good work!

examples/04_New Models.ipynb Outdated Show resolved Hide resolved
examples/04_New Models.ipynb Outdated Show resolved Hide resolved
examples/04_New Models.ipynb Outdated Show resolved Hide resolved
examples/04_New Models.ipynb Outdated Show resolved Hide resolved
examples/04_New Models.ipynb Outdated Show resolved Hide resolved
@kjjarvis kjjarvis requested a review from teubert October 13, 2023 21:49
@teubert teubert merged commit 70ab878 into dev Oct 13, 2023
29 checks passed
@teubert teubert deleted the examples/serialization branch October 13, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants