error: you are deriving `Ord` but have implemented `PartialOrd` explicitly --> engine/src/asset/sound/dat/finetune.rs:6:45 | 6 | #[derive(Debug, Clone, Copy, PartialEq, Eq, Ord)] | ^^^ | note: `PartialOrd` implemented here --> engine/src/asset/sound/dat/finetune.rs:74:1 | 74 | impl PartialOrd for FineTune { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_ord_xor_partial_ord = note: `#[deny(clippy::derive_ord_xor_partial_ord)]` on by default = note: this error originates in the derive macro `Ord` (in Nightly builds, run with -Z macro-backtrace for more info)

Clippy had exited with the 101 exit code

warning: casting `f64` to `usize` may lose the sign of the value --> engine/src/asset/sound/sample.rs:66:9 | 66 | (seconds * self.sample_rate as f64) as usize | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

warning: methods called `into_*` usually take `self` by value --> engine/src/asset/sound/sample.rs:21:28 | 21 | fn into_normalized_f32(&self) -> f32; | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `#[warn(clippy::wrong_self_convention)]` on by default

warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` --> engine/src/asset/sound/dat/t_song.rs:63:41 | 63 | / ... event.instrument.as_ref().map(|instrument| { 64 | | ... d.field_with("instrument", |f| match instrument { 65 | | ... None => f.write_fmt(format_args!("None")), 66 | | ... Some(instrument) => f.write_fmt(format_args!( ... | 73 | | ... }); 74 | | ... }); | |________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn help: try | 63 ~ if let Some(instrument) = event.instrument.as_ref() { d.field_with("instrument", |f| match instrument { 64 + None => f.write_fmt(format_args!("None")), 65 + Some(instrument) => f.write_fmt(format_args!( 66 + "Some({})", 67 + self.instruments 68 + .iter() 69 + .position(|i| Rc::ptr_eq(i, instrument)) 70 + .unwrap() 71 + )), 72 + }); } |

warning: variables can be used directly in the `format!` string --> engine/src/asset/sound/dat/t_song.rs:60:61 | 60 | ... f.write_fmt(format_args!("{:?}", volume)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 60 - f.write_fmt(format_args!("{:?}", volume)) 60 + f.write_fmt(format_args!("{volume:?}")) |

warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` --> engine/src/asset/sound/dat/t_song.rs:58:41 | 58 | / ... event.volume.map(|volume| { 59 | | ... d.field_with("volume", |f| { 60 | | ... f.write_fmt(format_args!("{:?}", volume)) 61 | | ... }); 62 | | ... }); | |________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn help: try | 58 ~ if let Some(volume) = event.volume { d.field_with("volume", |f| { 59 + f.write_fmt(format_args!("{:?}", volume)) 60 + }); } |

warning: variables can be used directly in the `format!` string --> engine/src/asset/sound/dat/t_song.rs:55:61 | 55 | ... f.write_fmt(format_args!("{:?}", note)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]` help: change this to | 55 - f.write_fmt(format_args!("{:?}", note)) 55 + f.write_fmt(format_args!("{note:?}")) |

warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` --> engine/src/asset/sound/dat/t_song.rs:53:41 | 53 | / ... event.note.map(|note| { 54 | | ... d.field_with("note", |f| { 55 | | ... f.write_fmt(format_args!("{:?}", note)) 56 | | ... }); 57 | | ... }); | |________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn = note: `#[warn(clippy::option_map_unit_fn)]` on by default help: try | 53 ~ if let Some(note) = event.note { d.field_with("note", |f| { 54 + f.write_fmt(format_args!("{:?}", note)) 55 + }); } |

warning: redundant closure --> engine/src/asset/sound/dat/t_song.rs:38:48 | 38 | ... if !row.iter().any(|c| c.has_content()) { | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `super::pattern_event::PatternEvent::has_content` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls = note: `#[warn(clippy::redundant_closure_for_method_calls)]` implied by `#[warn(clippy::pedantic)]`

warning: manual `Debug` impl does not include all fields --> engine/src/asset/sound/dat/t_song.rs:25:1 | 25 | / impl std::fmt::Debug for TSong { 26 | | fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { 27 | | f.debug_struct("TSong") 28 | | .field("bpm", &self.bpm) ... | 92 | | } 93 | | } | |_^ | note: this field is unused --> engine/src/asset/sound/dat/t_song.rs:20:5 | 20 | pub patterns: Vec<Rc<Pattern>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ note: this field is unused --> engine/src/asset/sound/dat/t_song.rs:22:5 | 22 | pub samples: Vec<Rc<TSample>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: consider including all fields in this `Debug` impl = help: consider calling `.finish_non_exhaustive()` if you intend to ignore fields = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_fields_in_debug = note: `#[warn(clippy::missing_fields_in_debug)]` implied by `#[warn(clippy::pedantic)]`

warning: called `map(<f>).unwrap_or(<a>)` on an `Option` value --> engine/src/asset/sound/dat/t_instrument.rs:270:20 | 270 | let next = next.map(|next| self.buffer[next] as f32).unwrap_or(0.); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or = note: `#[warn(clippy::map_unwrap_or)]` implied by `#[warn(clippy::pedantic)]` help: use `map_or(<a>, <f>)` instead | 270 - let next = next.map(|next| self.buffer[next] as f32).unwrap_or(0.); 270 + let next = next.map_or(0., |next| self.buffer[next] as f32); |

warning: casting `f64` to `usize` may lose the sign of the value --> engine/src/asset/sound/dat/t_instrument.rs:267:35 | 267 | let next = self.normalize(position as usize + 1); | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

warning: casting `f64` to `usize` may lose the sign of the value --> engine/src/asset/sound/dat/t_instrument.rs:264:41 | 264 | let Some(prev) = self.normalize(position as usize) else { | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

warning: this `let...else` may be rewritten with the `?` operator --> engine/src/asset/sound/dat/t_instrument.rs:264:9 | 264 | / let Some(prev) = self.normalize(position as usize) else { 265 | | return None; 266 | | }; | |__________^ help: replace it with: `let prev = self.normalize(position as usize)?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark = note: `#[warn(clippy::question_mark)]` on by default

warning: use of `expect` followed by a function call --> engine/src/asset/sound/dat/t_instrument.rs:32:52 | 32 | TInstrumentFlags::from_bits(flags).expect(&format!( | ____________________________________________________^ 33 | | "PatternEvent flags should be valid: received: {flags:b}" 34 | | )), | |__________________^ help: try: `unwrap_or_else(|| panic!("PatternEvent flags should be valid: received: {flags:b}"))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call

warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases --> engine/src/asset/sound/dat/pattern_event.rs:131:21 | 131 | pub instrument: Option<Option<Rc<TInstrument>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option = note: `#[warn(clippy::option_option)]` implied by `#[warn(clippy::pedantic)]`

warning: use of `expect` followed by a function call --> engine/src/asset/sound/dat/pattern_event.rs:66:53 | 66 | PatternEventFlags::from_bits(flags).expect(&format!( | _____________________________________________________^ 67 | | "PatternEvent flags should be valid: received: {flags:b}" 68 | | )), | |__________________^ help: try: `unwrap_or_else(|| panic!("PatternEvent flags should be valid: received: {flags:b}"))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call = note: `#[warn(clippy::expect_fun_call)]` on by default

warning: adding items after statements is confusing, since items exist from the start of the scope --> engine/src/asset/sound/dat/pattern_effect.rs:141:13 | 141 | use PatternEffect as E; | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements

warning: casting to the same type is unnecessary (`f64` -> `f64`) --> engine/src/asset/sound/dat/mixer.rs:488:50 | 488 | ... channel.pos_sample = sample.buffer.len_seconds() as f64 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sample.buffer.len_seconds()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: consider adding a `;` to the last statement for consistent formatting --> engine/src/asset/sound/dat/mixer.rs:488:29 | 488 | ... channel.pos_sample = sample.buffer.len_seconds() as f64 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `channel.pos_sample = sample.buffer.len_seconds() as f64;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

warning: using `clone` on type `PatternEffect` which implements the `Copy` trait --> engine/src/asset/sound/dat/mixer.rs:448:42 | 448 | channel.change_effect(i, effect.clone()); | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `effect` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: adding items after statements is confusing, since items exist from the start of the scope --> engine/src/asset/sound/dat/mixer.rs:450:17 | 450 | use PatternEffect as E; | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements = note: `#[warn(clippy::items_after_statements)]` implied by `#[warn(clippy::pedantic)]`

warning: it is more concise to loop over references to containers instead of using explicit iteration methods --> engine/src/asset/sound/dat/mixer.rs:325:24 | 325 | for channel in self.channels.iter_mut() { | ^^^^^^^^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `&mut self.channels` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop = note: `#[warn(clippy::explicit_iter_loop)]` implied by `#[warn(clippy::pedantic)]`

warning: this boolean expression can be simplified --> engine/src/asset/sound/dat/mixer.rs:208:16 | 208 | if !self.note.on | ________________^ 209 | | || (self.note.on 210 | | && envelope 211 | | .sustain 212 | | .map_or(true, |s| self.pos_volume_envelope < s)) | |________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool = note: `#[warn(clippy::nonminimal_bool)]` on by default help: try | 208 ~ if !(self.note.on && !envelope 209 + .sustain 210 + .map_or(true, |s| self.pos_volume_envelope < s)) | 208 ~ if !self.note.on || envelope 209 + .sustain 210 + .map_or(true, |s| self.pos_volume_envelope < s) |

warning: casting `i32` to `usize` may lose the sign of the value --> engine/src/asset/sound/dat/mixer.rs:167:54 | 167 | self.sample = instrument.samples[note.note() as usize].clone(); | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss = note: `#[warn(clippy::cast_sign_loss)]` implied by `#[warn(clippy::pedantic)]`

warning: assigning the result of `Clone::clone()` may be inefficient --> engine/src/asset/sound/dat/mixer.rs:167:21 | 167 | self.sample = instrument.samples[note.note() as usize].clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.sample.clone_from(&instrument.samples[note.note() as usize])` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` implied by `#[warn(clippy::pedantic)]`

warning: consider adding a `;` to the last statement for consistent formatting --> engine/src/asset/sound/dat/mixer.rs:121:17 | 121 | self.previous = None | ^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.previous = None;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

warning: used `cloned` where `copied` could be used instead --> engine/src/asset/sound/dat/mixer.rs:97:30 | 97 | ... .cloned() | ^^^^^^ help: try: `copied` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied

warning: used `cloned` where `copied` could be used instead --> engine/src/asset/sound/dat/mixer.rs:88:30 | 88 | ... .cloned() | ^^^^^^ help: try: `copied` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied = note: `#[warn(clippy::cloned_instead_of_copied)]` implied by `#[warn(clippy::pedantic)]`

warning: returning the result of a `let` binding from a block --> engine/src/asset/sound/dat/mixer.rs:129:9 | 115 | / let current_sample = if let Some((previous, position)) = &mut self.previous { 116 | | let factor = (*position / Self::SAMPLE_BLEND) as f32; 117 | | let previous_sample = previous.generate_sample(step); ... | 126 | | current_sample 127 | | }; | |__________- unnecessary `let` binding 128 | 129 | current_sample | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 115 ~ 116 | 117 ~ if let Some((previous, position)) = &mut self.previous { 118 + let factor = (*position / Self::SAMPLE_BLEND) as f32; 119 + let previous_sample = previous.generate_sample(step); 120 + 121 + *position += step; 122 + if *position >= Self::SAMPLE_BLEND { 123 + self.previous = None 124 + } 125 + 126 + previous_sample + factor * (current_sample - previous_sample) 127 + } else { 128 + current_sample 129 + } |

warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> engine/src/asset/sound/dat/finetune.rs:74:1 | 74 | / impl PartialOrd for FineTune { 75 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 76 | || self.cents.partial_cmp(&other.cents) 77 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 78 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default

warning: consider adding a `;` to the last statement for consistent formatting --> engine/src/asset/sound/dat/finetune.rs:54:9 | 54 | self.cents = self.cents.saturating_add(rhs.cents) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.cents = self.cents.saturating_add(rhs.cents);` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned = note: `#[warn(clippy::semicolon_if_nothing_returned)]` implied by `#[warn(clippy::pedantic)]`

warning: docs for function returning `Result` missing `# Errors` section --> engine/src/asset/pack_file.rs:26:5 | 26 | pub fn new(input: &[u8]) -> Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc = note: `#[warn(clippy::missing_errors_doc)]` implied by `#[warn(clippy::pedantic)]`

warning: docs for function which may panic missing `# Panics` section --> engine/src/asset/color_map.rs:18:5 | 18 | pub fn from_12_bit(color: u16) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first possible panic found here --> engine/src/asset/color_map.rs:20:9 | 20 | assert!(color <= 0xFFF, "12 bit color is smaller than 0xFFF"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc = note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]`

warning: unnested or-patterns --> engine/src/asset/sound/dat/pattern_effect.rs:121:13 | 121 | / PatternEffect::Porta(Porta::Tone(None)) 122 | | | PatternEffect::Porta(Porta::Slide { finetune: None, .. }) 123 | | | PatternEffect::Porta(Porta::Bump { finetune: None, .. }) 124 | | | PatternEffect::Volume(Volume::Slide(None)) 125 | | | PatternEffect::Volume(Volume::Bump { volume: None, .. }) 126 | | | PatternEffect::SampleOffset(None) | |___________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnested_or_patterns help: nest the patterns | 121 ~ PatternEffect::Porta(Porta::Tone(None) | Porta::Slide { finetune: None, .. } | 122 + Porta::Bump { finetune: None, .. }) | 123 + PatternEffect::Volume(Volume::Slide(None) | Volume::Bump { volume: None, .. }) 124 + | PatternEffect::SampleOffset(None) |

warning: unnested or-patterns --> engine/src/asset/sound/dat/mixer.rs:504:21 | 504 | / E::Volume(Volume::Bump { volume: None, .. }) 505 | | | E::Porta(Porta::Tone(None)) 506 | | | E::Porta(Porta::Bump { finetune: None, .. }) 507 | | | E::SampleOffset(None) => { | |___________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnested_or_patterns help: nest the patterns | 504 ~ E::Volume(Volume::Bump { volume: None, .. }) | 505 + E::Porta(Porta::Tone(None) | Porta::Bump { finetune: None, .. }) | 506 ~ E::SampleOffset(None) => { |

warning: unnested or-patterns --> engine/src/asset/sound/dat/mixer.rs:499:21 | 499 | / E::Volume(Volume::Slide(..)) 500 | | | E::Porta(Porta::Tone(..)) 501 | | | E::Porta(Porta::Slide { .. }) 502 | | | E::RetriggerNote(..) => {} | |__________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnested_or_patterns help: nest the patterns | 499 ~ E::Volume(Volume::Slide(..)) | E::Porta(Porta::Tone(..) | Porta::Slide { .. }) 500 ~ | E::RetriggerNote(..) => {} |

warning: unnested or-patterns --> engine/src/asset/sound/dat/mixer.rs:364:21 | 364 | / E::Speed(..) 365 | | | E::PatternBreak 366 | | | E::PatternJump(..) 367 | | | E::Volume(Volume::Set(..)) ... | 372 | | | E::SampleOffset(..) 373 | | | E::PlaybackDirection(..) => {} | |______________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnested_or_patterns note: the lint level is defined here --> engine/src/lib.rs:1:9 | 1 | #![warn(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::unnested_or_patterns)]` implied by `#[warn(clippy::pedantic)]` help: nest the patterns | 364 ~ E::Speed(..) | E::PatternBreak | E::PatternJump(..) | 365 + E::Volume(Volume::Set(..) | Volume::Bump { .. }) | 366 + E::Porta(Porta::Tone(..) | Porta::Bump { .. }) | E::GlobalVolume(..) | 367 ~ E::SampleOffset(..) | E::PlaybackDirection(..) => {} |

warning: this `if` statement can be collapsed --> engine/src/asset/sound/dat/mixer.rs:205:9 | 205 | / if let Some(instrument) = &self.instrument 206 | | && let TInstrumentVolume::Envelope(envelope) = &instrument.volume 207 | | { 208 | | if !self.note.on ... | 215 | | } 216 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 205 ~ if let Some(instrument) = &self.instrument && let TInstrumentVolume::Envelope(envelope) = &instrument.volume && (!self.note.on || (self.note.on 206 + && envelope 207 + .sustain 208 + .map_or(true, |s| self.pos_volume_envelope < s))) { 209 + self.pos_volume_envelope += 1; 210 + } |

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/