Align documentation by allowing Graph export in JSON & CSV formats #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QubitPi
changed the title
|
Hi @QubitPi and thanks for opening this PR! I think it is a good change and I'll have a look at the code now I put your name in system now, so the CLA check should be green on when re-run 👍 |
OskarDamkjaer
requested changes
Sep 21, 2023
|
Hi @OskarDamkjaer, thank you very much for the quick feedback. Your comment makes sense and I have change it accordingly (The multi-line breaks, I think, was inserted by auto-linting from git commit hook) |
OskarDamkjaer
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns graph export behavior with what's being documented, i.e. exporting in JSON and CSV
We like the feature of JSON export very much, because our research needs it a lot. Thanks a lot for developing this option, folks!
PS: I have also signed the CLA (jack20220723@gmail.com, QubitPi). Please let me know if I can help with anything else