Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align documentation by allowing Graph export in JSON & CSV formats #1939

Merged
merged 3 commits into from
Sep 22, 2023
+7 −4
Merged

Align documentation by allowing Graph export in JSON & CSV formats #1939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b392e8f
Align documentation by allowing Graph export in JSON & CSV format
QubitPi Sep 21, 2023
531ccfe
Address @OskarDamkjaer's comment
QubitPi Sep 22, 2023
1793635
Update tests
QubitPi Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e_tests/integration/data-export.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe('Data export', () => {
cy.executeCommand('MATCH (n:ExportTest) DETACH DELETE n')
})
const tests = [
{ panel: 'Visualization', expected: ['PNG', 'SVG'] },
{ panel: 'Visualization', expected: ['CSV', 'JSON', 'PNG', 'SVG'] },
{
panel: 'Plan',
expected: [
Expand Down
9 changes: 6 additions & 3 deletions src/browser/modules/Stream/CypherFrame/CypherFrame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,12 @@ export class CypherFrame extends Component<CypherFrameProps, CypherFrameState> {
const textDownloadEnabled = () =>
this.getRecords().length > 0 &&
this.state.openView &&
[ViewTypes.TEXT, ViewTypes.TABLE, ViewTypes.CODE].includes(
this.state.openView
)
[
ViewTypes.TEXT,
ViewTypes.TABLE,
ViewTypes.CODE,
ViewTypes.VISUALIZATION
].includes(this.state.openView)
const graphicsDownloadEnabled = () =>
this.visElement &&
this.state.openView &&
Expand Down