Refactor/xacro launch generic elite description - generic elite arm robot description #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig files, Refactored launch arguments-added use_gazebo arg in simulate_ec66.launch.py, restructured the packages
… the packages structure, modified urdf files to xacro using macros and yaml config files
…xibility to use other elite arms by just adding meshes and config files, renamed filed
padhupradheep
requested changes
Jul 2, 2024
| <xacro:include filename="$(find elite_description)/urdf/ec66_description.urdf" /> | ||
|
|
||
| <!-- Import ec66 urdf file with use_gazebo set to true --> | ||
| <xacro:include filename="$(find elite_description)/urdf/ec66_description.urdf.xacro"> |
There was a problem hiding this comment.
I think you need to update this.
2. made the elite arm xacro modular and compatible for both ec66 and cs66(yet to be added) 3. added initial positions for arm
AdarshKaran
force-pushed
the
refactor/xacro-launch-generic-elite-description
branch
from
f2509bc to
b704112
Compare
|
i have made the updates to the elite packages anna. kindly let me know if it is okay. I will then add the functionality for cs66 arm too |
|
But there is still an issue with the MoveIt package right? |
|
yes anna. But, the description files were updated. |
AdarshKaran
force-pushed
the
refactor/xacro-launch-generic-elite-description
branch
from
89a163d to
9312088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added use_gazebo and use_arm_type arguments, changed urdf to give flexibility to use other elite arms by just adding meshes and config files, renamed filed