Merge terraform provider tidydns #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatrx
reviewed
Nov 27, 2024
hatrx
reviewed
Nov 27, 2024
Comment on lines
+224
to
+233
| var interfaceRead interfaceRead | ||
| err = json.NewDecoder(res.Body).Decode(&interfaceRead) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return &InterfaceInfo{ | ||
| InterfaceIP: interfaceRead.Destination, | ||
| Interfacename: interfaceRead.Name, | ||
| }, nil |
There was a problem hiding this comment.
Is there any reason for creating a whole new interfaceRead type when you are just copying the data to InterfaceInfo? Seems like you only need one or the other
There was a problem hiding this comment.
I agree it might be superfluous, but I would prefer not breaking backward compatibility by changing the interface.
Also I think it might be wise to separate the internals from the interface we expose to the users of the go api.
hatrx
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.