Remove key check bypass and add ability to pass key in Authorization header #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will first check the secret key in the HTTP Authorization request header before falling back to checking for the query string for the key. Once WebMon and WebRef support the new method the check for
key
in the query string should be removed.Once you run the tests you can test manually test this with
curl
, e.g. the following two command should return the sameHalf the tests were updated to use the new Authorization header approach and the other half use the old method.
Ref: 5923: [LiveDataServer] Change API key handling
Short description of the changes:
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References