Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the command to be overridden for certain tools #96

Closed
nevinera opened this issue Jun 4, 2023 · 5 comments
Closed

Allow the command to be overridden for certain tools #96

nevinera opened this issue Jun 4, 2023 · 5 comments
Assignees

Comments

@nevinera
Copy link
Owner

nevinera commented Jun 4, 2023

This is mostly to enable further tools, but it could be useful for things like rspec as well. Right now, the runners define their own commands, but we could allow users to customize those commands through the configuration file:

rspec:
  changed_files: true
  filter_messages: false
  base_command: "rspec --fail-false -f json"
  environment:
    SIMPLECOV: "false"
    INTEGRATION_TESTING: "false"

We'd need to update the commands to be handled as strings instead of arrays of arguments, which means passing them through bash.. probably not a big deal. We'd also need to handle the supplying of additional environment variables via the usual spawn interface, which I think capture3 supports.

@nevinera
Copy link
Owner Author

nevinera commented Jun 4, 2023

One of the interesting things this allows is a custom tool, which requires both a supplied base command and a parser command that uses jq (or probably a script from your repository) to rewrite the output of whatever tool you're using into a json format we specify so the 'Custom::Parser' can read it. There's a lot to work out there, since there's no reason to restrict them to one custom tool..

@nevinera
Copy link
Owner Author

nevinera commented Mar 19, 2024

(alternatively, we can stick with the array-of-args approach, and only support overriding commands via config file, OR we could just do naive arg splitting ourselves if we get a string here).

@cdimartino
Copy link
Collaborator

Could accept an array of args in yaml also.

@nevinera
Copy link
Owner Author

nevinera commented May 7, 2024

Okay, I'm choosing an approach and splitting this ticket up.

  1. Array of args, yaml-only (Allow command to be overridden for a tool via yaml config #125)
  2. Support supplying environment to runners through yaml (Support supplying/overriding environment variables for runners via the yaml config #123)
  3. Support overriding the command for an individual runner on the cli (Support overriding the command for an individual runner on the CLI #124)

@nevinera
Copy link
Owner Author

nevinera commented May 7, 2024

Sliced up, closing in favor of the slices

@nevinera nevinera closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants