-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add CI workflow to check for backport request #5466
base: master
Are you sure you want to change the base?
Conversation
a28b643
to
68d439c
Compare
68d439c
to
8a6c116
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
8a6c116
to
774a7f3
Compare
on: | ||
pull_request: | ||
types: [opened, ready_for_review, reopened, synchronize, labeled] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should be on merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nobody cares after it's merged, so should be done beforehand.
But I'm not sure if that's a good flow:
- open PR
- get red CI
- trigger bot
- rerun CI again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nobody cares after it's merged, so should be done beforehand.
But... Notifications... 😥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As soon as the bot adds the label the labeled
trigger will cause the CI to be green - no manual interaction needed.
commit-message-check: | ||
if: github.event.pull_request.draft == false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also check, that it is not a PR from a bot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say we can exclude dependabot - because that is useless for that branch.
All other bots need manual review anyways and probably should also be ported.
☑️ Resolves
This adds a CI workflow to remember people to request a backport for our Vue3 migration.
🏁 Checklist
next
requested with a Vue 3 upgrade