Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add CI workflow to check for backport request #5466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 9, 2024

☑️ Resolves

This adds a CI workflow to remember people to request a backport for our Vue3 migration.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux susnux force-pushed the chore/require-vue3-backports branch from a28b643 to 68d439c Compare April 9, 2024 21:32
@susnux susnux force-pushed the chore/require-vue3-backports branch from 68d439c to 8a6c116 Compare April 9, 2024 21:34
@susnux susnux changed the title Chore/require vue3 backports chore: Add CI workflow to check for backport request Apr 9, 2024
@susnux susnux added 3. to review Waiting for reviews vue 3 Related to the vue 3 migration and removed backport-request labels Apr 9, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the chore/require-vue3-backports branch from 8a6c116 to 774a7f3 Compare April 9, 2024 21:53
Comment on lines +4 to +6
on:
pull_request:
types: [opened, ready_for_review, reopened, synchronize, labeled]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be on merged?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nobody cares after it's merged, so should be done beforehand.

But I'm not sure if that's a good flow:

  • open PR
  • get red CI
  • trigger bot
  • rerun CI again

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nobody cares after it's merged, so should be done beforehand.

But... Notifications... 😥

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as the bot adds the label the labeled trigger will cause the CI to be green - no manual interaction needed.

Comment on lines +15 to +16
commit-message-check:
if: github.event.pull_request.draft == false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also check, that it is not a PR from a bot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say we can exclude dependabot - because that is useless for that branch.
All other bots need manual review anyways and probably should also be ported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews vue 3 Related to the vue 3 migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants