Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add CI workflow to check for backport request #5466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: Add CI workflow to check for backport request #5466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/ensure-backported.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@

name: Ensure changes are migrated to Vue3

on:
pull_request:
types: [opened, ready_for_review, reopened, synchronize, labeled]
Comment on lines +4 to +6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be on merged?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nobody cares after it's merged, so should be done beforehand.

But I'm not sure if that's a good flow:

  • open PR
  • get red CI
  • trigger bot
  • rerun CI again

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nobody cares after it's merged, so should be done beforehand.

But... Notifications... 😥

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as the bot adds the label the labeled trigger will cause the CI to be green - no manual interaction needed.

branches:
- main
- master

permissions:
contents: read

jobs:
commit-message-check:
if: github.event.pull_request.draft == false
Comment on lines +15 to +16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also check, that it is not a PR from a bot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say we can exclude dependabot - because that is useless for that branch.
All other bots need manual review anyways and probably should also be ported.


name: Require Vue3 migration backport
runs-on: ubuntu-latest

steps:
- name: Run check
run: |
if ! ${{ contains(github.event.pull_request.labels.*.name, 'backport-request') }}; then
echo -e "Please request a backport to the next-branch for our ongoing Vue 3 migration.\nSimply create a comment '/backport to next' and handle the backport afterwards.";
exit 1;
else
echo "Backport request is already created. Thank you!"
fi
Loading