Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/error display name #278

Merged
merged 3 commits into from
Apr 2, 2024
Merged

fix/error display name #278

merged 3 commits into from
Apr 2, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Apr 2, 2024

  • fix: Set displayname for error response
  • chore: Remove compatibility check for display name

We do not store the display name in the database as it might be used by native WebDAV locking for weird identifiers from the webdav clients. However with that we need to enhance the lock object with the actual display name before using it in an error response.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Apr 2, 2024
@juliusknorr
Copy link
Member Author

/backport to stable28

@juliusknorr
Copy link
Member Author

/backport 3dff56b to stable27

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the fix/error-display-name branch from f5ab88b to 3c5fa7d Compare April 2, 2024 08:55
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the fix/error-display-name branch from 3c5fa7d to 3440960 Compare April 2, 2024 09:00
@juliusknorr juliusknorr requested a review from come-nc April 2, 2024 09:25
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working.

@come-nc come-nc merged commit 572727f into main Apr 2, 2024
44 checks passed
@come-nc come-nc deleted the fix/error-display-name branch April 2, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants