Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AclStateButton): Increase contrast for inherited permissions #3050

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix(AclStateButton): Increase contrast for inherited permissions #3050

merged 1 commit into from
Jul 22, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Jul 11, 2024 •
edited
Loading

Description

Increase contrast for inherited icons as is now

Photos (Subtle change)

Before After
existing-contrast max-contrast

@nfebe nfebe added enhancement 3. to review Items that need to be reviewed labels Jul 11, 2024
@nfebe nfebe force-pushed the feat/distinguish-inherited-permissions branch from 9c8299f to 8a225d7 Compare July 18, 2024 09:34
@nfebe
fix(AclStateButton): Increase contrast for inherited permissions
debe182 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the feat/distinguish-inherited-permissions branch from 8a225d7 to debe182 Compare July 18, 2024 13:16
@nfebe nfebe marked this pull request as ready for review July 18, 2024 13:19
@nfebe nfebe merged commit 59fa86e into master Jul 22, 2024
45 checks passed
@nfebe nfebe deleted the feat/distinguish-inherited-permissions branch July 22, 2024 07:10
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorbaugh sorbaugh sorbaugh approved these changes

@artonge artonge artonge approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees
No one assigned
Labels
3. to review Items that need to be reviewed enhancement feedback-requested
Projects
🖍 Design team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nfebe @artonge @sorbaugh