Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dynamite/numbers #999

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Fix/dynamite/numbers #999

merged 3 commits into from
Oct 23, 2023

Conversation

Leptopoda
Copy link
Member

@Leptopoda Leptopoda commented Oct 19, 2023

Needed for some future dynamite someOfs cleanups.
Depends on #997

Currently the provisioning_api spec looks broken so not yet mergable.
Depends on nextcloud/server#41045

@provokateurin
Copy link
Member

Server fix was merged

provokateurin and others added 3 commits October 23, 2023 15:52
Signed-off-by: jld3103 <jld3103yt@gmail.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
…into double

Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
@Leptopoda Leptopoda removed the blocked Blocked on other things label Oct 23, 2023
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but please also review the changes that I made

@Leptopoda
Copy link
Member Author

@provokateurin LGTM
I can't approve as I opened the PR

@Leptopoda Leptopoda merged commit 35d8409 into main Oct 23, 2023
5 checks passed
@Leptopoda Leptopoda deleted the fix/dynamite/numbers branch October 23, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants