-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scopes): Allow apps to define different API scopes for different… #24
Conversation
26debec
to
c11ce8f
Compare
@nickvergessen would it be possible to get this done before the server release so we can update it in the server? This is quite a significant change so it would be great to have it from the start. |
The title of the specs should reflect the scope so a short note should be prepended to the current titles. |
04a3b99
to
b5b1e4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the code.
I'll give it some testing with the apps that are supported to check for any problems.
0358899
to
93a6490
Compare
Please rebase again 😬 |
93a6490
to
d9e3844
Compare
I had rebased before, so was only the rename from All done now |
Running in server (core):
|
And a few more of these errors in other apps:
|
bf187cd
to
fd01672
Compare
8d60dd8
to
d3bd5c3
Compare
e0274d7
to
ac83995
Compare
ac83995
to
94962d4
Compare
Rebased after #44 |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
810ef64
to
4d20003
Compare
Rebased again to solve the conflicts from #72 |
Arg
Need to fix the logic more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you update the demo PRs you did so I can review the changes in those and check that everything is good?
Signed-off-by: Joas Schilling <coding@schilljs.com>
1f914f7
to
ed40c15
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
Running this in Talk results in
But the sum of all routes is 86 and the full spec has only 85 🤔 |
From the server branch: |
Because
Fixed locally. Checking atm why comments e.g. generates a |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Both fixed and pushed now |
Signed-off-by: Joas Schilling <coding@schilljs.com>
8746cb0
to
a479a34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice 🎉
… target clients
Sibling PRs
OpenAPI
attribute: Add OpenAPI attribute to allow multiple scopes server#41175Possible optimisations
NoAdminRequired
Fix #20