Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openapi update #10856

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Openapi update #10856

merged 3 commits into from
Jan 18, 2024

Conversation

nickvergessen
Copy link
Member

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants labels Nov 10, 2023
@nickvergessen nickvergessen added this to the 💙 Next Beta (28) milestone Nov 10, 2023
@nickvergessen nickvergessen self-assigned this Nov 10, 2023
@nickvergessen nickvergessen mentioned this pull request Nov 10, 2023
Merged
4 tasks
@nickvergessen nickvergessen marked this pull request as draft January 10, 2024 10:10
@nickvergessen
Copy link
Member Author

Setting to draft as nextcloud/openapi-extractor#24 is still not merged

@nickvergessen nickvergessen force-pushed the openapi-update branch 2 times, most recently from 096ba4e to 7300752 Compare January 17, 2024 14:52
@nickvergessen nickvergessen mentioned this pull request Jan 17, 2024
Merged
5 tasks
@nickvergessen
fix(openapi): Reorganize openapi specs
144c9c1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Update extractor
ae568ed 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
chore(assets): Recreate openapi specs
bac9eb8 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen marked this pull request as ready for review January 18, 2024 14:32
@provokateurin
Copy link
Member

I think we should wait a bit more if I find any more problems while doing the server PR.

@nickvergessen
Copy link
Member Author

I think we should wait a bit more if I find any more problems while doing the server PR.

I need to get rid of this branch. Can do follow up bumps if needed, but the branch starting with o is breaking my autocomplete tabbing with origin for way too long already 👯

@provokateurin
Copy link
Member

Ok 👍

@nickvergessen nickvergessen merged commit 3902cba into main Jan 18, 2024
53 of 54 checks passed
@nickvergessen nickvergessen deleted the openapi-update branch January 18, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

Assignees

@nickvergessen nickvergessen

Labels
2. developing enhancement feature: api 🛠️ OCS API for conversations, chats and participants
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @provokateurin