Avatar new style #33752
Merged
Avatar new style #33752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CarlSchwan
force-pushed
the
avatar-new-style
branch
from
1c36c49
to
6a32033
Compare
CarlSchwan
commented
Sep 8, 2022
come-nc
reviewed
Sep 8, 2022
CarlSchwan
force-pushed
the
avatar-new-style
branch
from
77ba09f
to
7cd934a
Compare
come-nc
approved these changes
Sep 8, 2022
ChristophWurst
approved these changes
Sep 8, 2022
CarlSchwan
force-pushed
the
avatar-new-style
branch
from
7cd934a
to
35813f1
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
And better caching policy Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
avatar-new-style
branch
2 times, most recently
from
aea3d11
to
61ee0d9
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
avatar-new-style
branch
from
61ee0d9
to
bc9a488
Compare
|
ci failure unrelated (sharing) |
ghost
mentioned this pull request
9 tasks
ChristophWurst
added
the
pending documentation
|
This should be documented so apps can adjust. I still see {"reqId":"wfo0ZhmZNBDzXGliaakN","level":0,"time":"2023-01-26T09:32:37+00:00","remoteAddr":"127.0.0.1","user":"admin","app":"core","method":"GET","url":"/avatar/admin/32?v=4","message":"Avatar requested in deprecated size 32","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Firefox/108.0","version":"26.0.0.2","data":{"app":"core"}}in my log when I open Dashboard |
This was referenced Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dark theme:
White theme:
Also fix a bug where the avatars where not generated with imagick because the font path was not correct
Todos: