Explicitly close the directory stream #41013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solracsf
added
2. developing
solracsf
added
3. to review
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Typo Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
susnux
requested review from
nickvergessen,
icewind1991,
a team,
ArtificialOwl,
Altahrim and
artonge
and removed request for
a team
Altahrim
approved these changes
Oct 23, 2023
nickvergessen
approved these changes
Oct 23, 2023
artonge
approved these changes
Oct 23, 2023
solracsf
added
4. to release
icewind1991
requested changes
Oct 25, 2023
|
You're right, closing then as there is no point to do it. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The directory handle
$dhis explicitly closed usingclosedir($dh)to release resources after iterating through the directory.This ensures proper resource management.
Checklist