fix(settings): apps list html validation and loading icon #41035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
bug
3. to review
susnux
approved these changes
Oct 21, 2023
JuliaKirschenheuter
approved these changes
Oct 23, 2023
|
conflicts |
ShGKme
force-pushed
the
fix/37092/apps-list--html-validation
branch
from
ed7a946 to
1d45bed
Compare
- Replace invalid `width="100%"` attribute - Add empty required `alt` Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
- fix setting loading classes - also removes invalid HTML attributes, there is no such props in `NcContent` Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/37092/apps-list--html-validation
branch
from
1d45bed to
7e94468
Compare
|
cypress unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
imgelement must have analtattribute, except under certain conditions.alt. It is fine as the app image has no important information in addition to name and description100%for attributewidthon elementimg: Expected a digit but saw % instead.content-classnot allowed on elementdivat this point.content-classprop onNcContent. Just removed, loading icon is already set onNcAppContentnavigation-classnot allowed on elementdivat this point.navigation-classprop onNcContent. Removed and set as a normal class onNcAppNavigationChecklist