-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files_versions): Check for user and owner before call getUserFolder #41749
Conversation
3a119f5
to
f42963d
Compare
d0e84b5
to
24e136a
Compare
628e261
to
38f442a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change :).
One comment through.
…etUserFolder Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Fix typo Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Fix Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Fix Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Fix Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Optimize DI Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Switch to DI Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> userSession does not contain null Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Restore phpdoc annots Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
b04f176
to
4173dfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
backport to 28? |
/backport to stable28 |
/backport to stable27 |
/backport to stable26 |
Just seeing it was attempted to be triggered on the 27 backport |
Explicitly check both values to avoid
false
ornull
values being passed togetUserFolder()
calls.Checklist