Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate app dir owner check to new SetupCheck API #42176

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Migrate app dir owner check to new SetupCheck API #42176

merged 2 commits into from
Jan 9, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Dec 12, 2023 •
edited
Loading

Summary

Migrate app dir owner check to new SetupCheck API

Checklist

@come-nc come-nc added the 2. developing Work in progress label Dec 12, 2023
@come-nc come-nc added this to the Nextcloud 29 milestone Dec 12, 2023
@come-nc come-nc self-assigned this Dec 12, 2023
This was referenced Dec 12, 2023
Closed
Merged
@come-nc come-nc force-pushed the feat/migrate-opcache-check-to-new-api branch 2 times, most recently from e832c14 to 94d0399 Compare January 8, 2024 15:03
Base automatically changed from feat/migrate-opcache-check-to-new-api to master January 8, 2024 16:35
@come-nc
Migrate app dir owner check to SetupCheck API
3d4c4f1 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the feat/migrate-appdirowner-setupcheck branch from b9aedfe to 3d4c4f1 Compare January 8, 2024 16:37
@come-nc come-nc marked this pull request as ready for review January 8, 2024 16:38
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 8, 2024
@come-nc come-nc requested review from a team, ArtificialOwl, icewind1991, nfebe and Altahrim and removed request for a team January 8, 2024 16:39
@come-nc come-nc enabled auto-merge January 8, 2024 17:05
@come-nc come-nc disabled auto-merge January 9, 2024 08:42
@come-nc

This comment was marked as outdated.

Sign in to view
@come-nc
Migrate tests for AppDirsWithDifferentOwner setup check
d2dbe1c 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Copy link
Contributor Author

come-nc commented Jan 9, 2024

Remaining drone failures are not related

skjnldsv
skjnldsv approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@come-nc come-nc merged commit 012dcbb into master Jan 9, 2024
49 of 50 checks passed
@come-nc come-nc deleted the feat/migrate-appdirowner-setupcheck branch January 9, 2024 13:41
This was referenced Jan 15, 2024
Merged
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
3 participants
@come-nc @ArtificialOwl @skjnldsv