Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate PHP imagick module check to new SetupCheck API #42177

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Dec 12, 2023

Summary

Migrate PHP imagick module check to new SetupCheck API.
It is in the theming application as it was only tested when this application is enabled. I also merged the SVG support check in it to be consistent.

Checklist

@come-nc come-nc self-assigned this Dec 12, 2023
@come-nc
Copy link
Contributor Author

come-nc commented Dec 12, 2023

  • Check if the linked documentation page documents imagick module, otherwise fix documentation or change/remove link

@come-nc come-nc force-pushed the feat/migrate-appdirowner-setupcheck branch from b9aedfe to 3d4c4f1 Compare January 8, 2024 16:37
Base automatically changed from feat/migrate-appdirowner-setupcheck to master January 9, 2024 13:41
@come-nc come-nc force-pushed the feat/migrate-imagick-setupcheck branch from 427e41b to dc46b5d Compare January 9, 2024 13:44
@come-nc come-nc marked this pull request as ready for review January 9, 2024 13:44
@come-nc come-nc added the 3. to review Waiting for reviews label Jan 9, 2024
@come-nc come-nc added this to the Nextcloud 29 milestone Jan 9, 2024
@come-nc come-nc force-pushed the feat/migrate-imagick-setupcheck branch from dc46b5d to 3624b17 Compare January 9, 2024 13:56
@come-nc come-nc requested review from a team, ArtificialOwl, Altahrim and nfebe and removed request for a team January 9, 2024 13:57
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the feat/migrate-imagick-setupcheck branch from 3624b17 to d1f2add Compare January 11, 2024 10:29
@come-nc come-nc requested a review from susnux January 11, 2024 10:29
@come-nc come-nc merged commit d128b4a into master Jan 11, 2024
49 of 50 checks passed
@come-nc come-nc deleted the feat/migrate-imagick-setupcheck branch January 11, 2024 13:36
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants