-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: expand select and group by for calendar reminder backend #47399
Conversation
|
/backport to stable30 |
|
This change fails for me with share notifications |
f00a43b
to
433bf0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with ONLY_FULL_GROUP_BY on in mariadb. Master fails, this works
👍
Other tests are failing now, after rebase |
433bf0d
to
8443b63
Compare
I've previously submitted a, perhaps, less error-prone PR here (closed because this one was older) : #47996 |
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
8443b63
to
ab3a239
Compare
Checklist