Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(caldav): Add all selected columns to GROUP BY #47996

Closed
wants to merge 1 commit into from
Closed

fix(caldav): Add all selected columns to GROUP BY #47996

wants to merge 1 commit into from

Conversation

solracsf
Copy link
Member

Summary

Added all the fields from the SELECT clause to the GROUP BY. This way, the query adheres to the ONLY_FULL_GROUP_BY mode.

Checklist

@tcitworld tcitworld mentioned this pull request Sep 15, 2024
Open
@ChristophWurst
Copy link
Member

Seems related to 67957e9

@ChristophWurst
Copy link
Member

/backport d100c20 to stable30

@solracsf
fix(caldav): Add all selected columns to GROUP BY
932bf6e 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: code style

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@ChristophWurst
Copy link
Member

Dup of #47399

@solracsf
Copy link
Member Author

Okay! Feel free to close here then 👍

@solracsf solracsf closed this Sep 15, 2024
@solracsf solracsf deleted the addAllToGroupBy branch September 15, 2024 07:57
@solracsf solracsf mentioned this pull request Sep 18, 2024
Merged
4 tasks
@ChristophWurst ChristophWurst restored the addAllToGroupBy branch September 18, 2024 21:09
@ChristophWurst
Copy link
Member

Unfortunately this fails, at least with strict mysql

An exception occurred while executing a query: SQLSTATE[42000]: Syntax error or access violation: 1055 'nextcloud.cr.calendar_id' isn't in GROUP BY

@ChristophWurst ChristophWurst deleted the addAllToGroupBy branch September 18, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@miaulalala miaulalala Awaiting requested review from miaulalala

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@hamza221 hamza221 Awaiting requested review from hamza221

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Core Error after Upgrade to Nextcloud Hub 9 (30.0.0)
2 participants
@solracsf @ChristophWurst