-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
follow-up(Recording consent): minor enhancements #10759
Comments
with internal signling only, we fetch conversation within an interval, and show context you mentioned. but with HPB it wait for signaling message. It seems like when the share owner leaves conversation, it's removed on server side. So, we may track signaling message, that owner left the room, and fetch the conversation within some timeout => and if it was deleted, all should go back to normal => will raise a follow-up issue |
A minor detail: when the device selector is shown in request password/video verification clicking on Always show preview for this conversation or in the menu to start a silent call has no effect (the checkbox is not modified, and the menu is not opened).
Nevertheless, those options should not be even visible, because every time a password is requested again a new room will be created, so there is no point in remembering Always show preview for this conversation, and the call should not be silently started, as the owner of the file should be notified that a password is being requested.
Originally posted by @danxuliu in #10633 (review)
The text was updated successfully, but these errors were encountered: