-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make browserCheck an util instead of mixin #11009
Conversation
- There is no need to be a mixin, it has nothing Vue-related or reactive - Move to utils - Refactor computed and Vue component methods to exported constants and functions Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flawless. Tested in Chrome + Firefox
One non-blocking comment:
- faisalman/ua-parser-js#599 is fixed in 1.0.32 Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Also tested with "real safari" works as well :)
/backport to stable28 |
As I understood the problem, it was not reproducible in Safari on Mac. Only on specific old versions on iPad. |
/backport to stable27 |
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
No visual changes
🚧 Tasks
browserCheck
to utilscallButtonTooltipText
toCallButton
as it was supposed to be used only inCallButton
🏁 Checklist