Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(screensharing): switch focus to screenshare button instead of end call button #11582

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Feat(screensharing): switch focus to screenshare button instead of end call button #11582

merged 1 commit into from
Feb 16, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Feb 13, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image

🚧 Tasks

  • Code review
  • Design review

@DorraJaouad DorraJaouad requested a review from Antreesy February 13, 2024 06:58
@DorraJaouad DorraJaouad self-assigned this Feb 13, 2024
@DorraJaouad DorraJaouad added feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client labels Feb 13, 2024
@DorraJaouad DorraJaouad added this to the 💞 Next Major (29) milestone Feb 13, 2024
@DorraJaouad
Copy link
Contributor Author

/backport to stable28

Antreesy
Antreesy approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual and code changes are good, I'd just refactor TopBar component a bit, as we're touching it

src/components/TopBar/TopBarMediaControls.vue Show resolved Hide resolved
src/components/TopBar/TopBar.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallButton.vue Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the fix/10566/in-call-highlights branch 2 times, most recently from 4ab356c to 000e046 Compare February 14, 2024 12:44
Antreesy
Antreesy reviewed Feb 14, 2024
View reviewed changes
src/components/CallView/shared/LocalAudioControlButton.vue Show resolved Hide resolved
src/components/TopBar/TopBarMediaControls.vue Outdated Show resolved Hide resolved
src/components/TopBar/TopBarMediaControls.vue Outdated Show resolved Hide resolved
src/components/TopBar/TopBarMediaControls.vue Outdated Show resolved Hide resolved
src/components/TopBar/TopBar.vue Show resolved Hide resolved
Antreesy
Antreesy reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple more places:

spreed/src/components/TopBar/ReactionMenu.vue

Line 29 in cabba5a

fill-color="#ffffff" />

spreed/src/components/TopBar/TopBarMenu.vue

Line 34 in 3e26bbf

<HandBackLeft :size="18" fill-color="#ffffff" />

spreed/src/components/TopBar/TopBarMenu.vue

Line 47 in 3e26bbf

fill-color="#ffffff" />

src/components/TopBar/TopBar.vue Show resolved Hide resolved
src/components/TopBar/TopBar.vue Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the fix/10566/in-call-highlights branch from b67bdcb to eda08e9 Compare February 16, 2024 16:01
@DorraJaouad
feat: switch focus to screenshare button instead of end call button
cc768b6 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/10566/in-call-highlights branch from eda08e9 to cc768b6 Compare February 16, 2024 19:43
@DorraJaouad DorraJaouad merged commit a86db03 into main Feb 16, 2024
45 checks passed
@DorraJaouad DorraJaouad deleted the fix/10566/in-call-highlights branch February 16, 2024 20:52
@backportbot backportbot bot mentioned this pull request Feb 16, 2024
Closed
2 tasks
@Antreesy Antreesy mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

"Leave call" button very present during screenshare
2 participants
@DorraJaouad @Antreesy