Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MessagesSystemGroup): collapse actor removed messages, collapse previously open groups with unread marker #11876

Merged
merged 3 commits into from
Mar 25, 2024
Merged

fix(MessagesSystemGroup): collapse actor removed messages, collapse previously open groups with unread marker #11876

merged 3 commits into from
Mar 25, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 20, 2024 •
edited
Loading

☑️ Resolves

  • Ref Collapsed messages | minor bugs #11484
    • message group should be collapsed, as soon as unread marker is moved from it
    • only manually open groups will be opened after list re-render, rest will follow the rules

Rest

  • group messages ilke Administrator removed A, B and 3 other participants (copy-paster from 'user-added')
  • cycle through only existing group keys when soft updating
    • we could remove group just before in previous cycle

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Before After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

@Antreesy Antreesy added this to the 💞 Next Beta (29) milestone Mar 20, 2024
@Antreesy Antreesy requested a review from DorraJaouad March 20, 2024 13:54
@Antreesy Antreesy self-assigned this Mar 20, 2024
Antreesy added 3 commits March 21, 2024 12:35
@Antreesy
feat(MessagesSystemGroup): group user removed by one actor
58b2e3c 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(MessagesList): cycle through only existing group keys when soft u…
15380b7 
…pdating

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(MessagesSystemGroup): collapse groups, if they don't contain unre…
1f82203 
…ad messages

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/11484/system-message-grouping branch from ccc48df to 1f82203 Compare March 21, 2024 11:36
@Antreesy Antreesy changed the title fix(MessagesSystemGroup): filter out duplicate messages from prepared group before render fix(MessagesSystemGroup): collapse actor removed messages, collapse previously open groups with unread marker Mar 21, 2024
DorraJaouad
DorraJaouad approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test unread marker position but logic looks good 🦅.

Tested the rest ✅

@Antreesy Antreesy merged commit 09fadad into main Mar 25, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/11484/system-message-grouping branch March 25, 2024 11:02
@DorraJaouad DorraJaouad mentioned this pull request Apr 2, 2024
Merged
7 tasks
@DorraJaouad DorraJaouad mentioned this pull request Jun 26, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.5
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @DorraJaouad @nickvergessen