Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(MessagesList): Refactor scrolling #11934

Merged
merged 4 commits into from
Mar 27, 2024
Merged

chore(MessagesList): Refactor scrolling #11934

merged 4 commits into from
Mar 27, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Mar 26, 2024 •
edited
Loading

Includes

  • Restrict Placeholder to not to create scrolling for the chat when it is there
  • Message Highlight is event-driven now instead of ref-oriented, saves some computations
  • Adjust fallback visible message to include only actual visible messages (e.g: not reaction system messages)

Follow-up:

  • Removed extra steps in scrolling and improved remaining.

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad
chore(MessagesList): adjust loading placeholder to not to exceed view…
2c21068 
… height

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added this to the 💞 Next Beta (29) milestone Mar 26, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy March 26, 2024 11:41
@DorraJaouad DorraJaouad self-assigned this Mar 26, 2024
Antreesy
Antreesy reviewed Mar 26, 2024
View reviewed changes
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
@Antreesy Antreesy force-pushed the fix/noid/focusing-on-message branch from 408512a to f1e90ea Compare March 27, 2024 08:25
@DorraJaouad DorraJaouad force-pushed the fix/noid/focusing-on-message branch from f1e90ea to bbd6a86 Compare March 27, 2024 09:51
@DorraJaouad
fix: switch highlighting behavior to event-driven
7bc38ae 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix(MessagesList): remove legacy mode
785a5ee 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/noid/focusing-on-message branch from bbd6a86 to f3da3a9 Compare March 27, 2024 10:22
Antreesy
Antreesy approved these changes Mar 27, 2024
View reviewed changes
src/store/messagesStore.js Outdated Show resolved Hide resolved
src/store/messagesStore.js Show resolved Hide resolved
@DorraJaouad
chore(MessagesStore): adjust fallback displayable messages
9184ceb 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/noid/focusing-on-message branch from f3da3a9 to 9184ceb Compare March 27, 2024 10:58
@DorraJaouad DorraJaouad merged commit 0afabde into main Mar 27, 2024
46 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/focusing-on-message branch March 27, 2024 11:12
@DorraJaouad DorraJaouad mentioned this pull request Mar 27, 2024
Merged
9 tasks
@nextcloud nextcloud deleted a comment from backportbot bot Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
feature: chat 💬 Chat and system messages technical debt
Projects
None yet
Milestone
v19.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
3 participants
@DorraJaouad @Antreesy @nickvergessen