Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(calls): Allow moderators to download a call participants list - frontend #13557

Merged
merged 2 commits into from
Oct 18, 2024
Merged

feat(calls): Allow moderators to download a call participants list - frontend #13557

merged 2 commits into from
Oct 18, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Oct 15, 2024 •
edited by Antreesy
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

During call Output
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad self-assigned this Oct 15, 2024
@DorraJaouad DorraJaouad force-pushed the feat/13453/download-call-participants-frontend branch from f12124b to 565a2f5 Compare October 15, 2024 14:13
@DorraJaouad DorraJaouad added this to the 🌠 Next Minor (30) milestone Oct 15, 2024
@DorraJaouad DorraJaouad marked this pull request as ready for review October 15, 2024 14:14
@DorraJaouad DorraJaouad requested a review from Antreesy October 15, 2024 14:15
@Ivansss
Copy link
Member

Ivansss commented Oct 15, 2024

Just as an idea, would be possible to add this option somewhere in the participant list?

Somewhere here maybe?
Screenshot 2024-10-15 at 16 30 24

@Antreesy
Copy link
Contributor

Somewhere here maybe?

Maybe as a second entry, if it would feel needed there.
But then this section needs some rework

@DorraJaouad
Copy link
Contributor Author

Maybe as a second entry, if it would feel needed there.

I'd go for one entry only IMO.

Just as an idea, would be possible to add this option somewhere in the participant list?

We also thought it will fit better in participants tab but the current design doesn't help much in putting it there :').

@DorraJaouad DorraJaouad force-pushed the feat/13453/download-call-participants-frontend branch from 565a2f5 to 05934fc Compare October 16, 2024 08:50
Antreesy
Antreesy approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Filename change we can do separately on backend, right?

@DorraJaouad
Copy link
Contributor Author

DorraJaouad commented Oct 16, 2024 •
edited
Loading

Filename change we can do separately on backend

As it is received from backend, I assumed it will be modified there. I am fine with adding it in this PR

@DorraJaouad DorraJaouad force-pushed the feat/13453/download-call-participants-frontend branch from fad6c90 to 63ba64a Compare October 17, 2024 18:32
DorraJaouad and others added 2 commits October 18, 2024 08:37
@DorraJaouad @nickvergessen
feat(Call): allow moderators to download current attendance list
40d8d71 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@nickvergessen
fix(call): Respect user timezone for date
0a2b093 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feat/13453/download-call-participants-frontend branch from 63ba64a to 0a2b093 Compare October 18, 2024 06:38
@nickvergessen
Copy link
Member

Pushed the user timezone thing

nickvergessen
nickvergessen approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now and fine API wise

@nickvergessen nickvergessen merged commit 5271dab into main Oct 18, 2024
69 checks passed
@nickvergessen nickvergessen deleted the feat/13453/download-call-participants-frontend branch October 18, 2024 08:15
@nickvergessen
Copy link
Member

/backport to stable30

@backportbot backportbot bot mentioned this pull request Oct 18, 2024
Merged
Antreesy
Antreesy reviewed Oct 24, 2024
View reviewed changes
src/components/TopBar/TopBarMenu.vue
@@ -139,6 +139,14 @@
</template>
{{ t('spreed', 'Conversation settings') }}
</NcActionButton>
<NcActionLink v-if="isInCall && canModerate"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capability check is missing

@DorraJaouad DorraJaouad mentioned this pull request Oct 25, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
enhancement feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
4 participants
@DorraJaouad @Ivansss @Antreesy @nickvergessen