Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openapi): Improve empty array cases #13830

Merged
merged 19 commits into from
Nov 22, 2024
Merged

fix(openapi): Improve empty array cases #13830

merged 19 commits into from
Nov 22, 2024

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants labels Nov 20, 2024
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Nov 20, 2024
@nickvergessen nickvergessen self-assigned this Nov 20, 2024
@nickvergessen nickvergessen force-pushed the bugfix/noid/improve-openapi-handling branch from 9fbe4d2 to a9be671 Compare November 20, 2024 23:17
@nickvergessen nickvergessen mentioned this pull request Nov 20, 2024
Closed
3 tasks
provokateurin
provokateurin reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if openapi-extractor should skip the response type when the only type is null just like it already does with array<empty>. Both essentially mean "there is nothing to look at" and it would make the spec a bit cleaner (and remove almost all spec changes in this PR).

lib/Controller/TempAvatarController.php Show resolved Hide resolved
lib/Capabilities.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the bugfix/noid/improve-openapi-handling branch from a9be671 to 7d9f7e3 Compare November 21, 2024 21:46
@nickvergessen nickvergessen mentioned this pull request Nov 21, 2024
Merged
4 tasks
@nickvergessen nickvergessen force-pushed the bugfix/noid/improve-openapi-handling branch from 90b6a0c to b3eec44 Compare November 21, 2024 22:10
@nickvergessen
fix(openapi): Remove empty array on recording backend responses
4b4c144 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Fix documentation of ban API
590272d 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Adjust internal HostedSignalingServerController
d49f162 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Fix breakout rooms being lists
3be2e56 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Remove empty array return from federation
7b086a4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Remove empty array from internal Guests API
9cb64ed 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Remove empty arrays from files integration API
07a2623 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Fix user avatar API to not return empty arrays
6c2ad38 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Change things that don't raise any questions
0da1cf1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Fix signaling handling
c47ecdb 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Fix signaling API empty responses
0978b92 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Remove empty array from bot responses
9db19a9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Fix call API empty arrays
110062e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
test: Fix integration test function with returning null :D
336c477 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(room): Fix undefined variable in federated calls
ff438bc 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
chore(assets): Recompile assets
8534882 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(federation): Fix expected status code
37c61aa 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(federation): Allow federation sync to always toggle recording con…
ad5f9a5 
…sent

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/improve-openapi-handling branch from ca580a2 to 1c7b81f Compare November 22, 2024 09:15
@nickvergessen
fix(federation): Allow federation error responses to be read twice
15410d5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/improve-openapi-handling branch from 1c7b81f to 15410d5 Compare November 22, 2024 10:01
@nickvergessen
Copy link
Member Author

/backport ad5f9a5,15410d5e447b969be926e50ccefdbc5f786c5c7e,ff438bc23bb75156fc6c3a7101ea35e392c16a24 to stable30

@nickvergessen nickvergessen merged commit 000cd81 into main Nov 22, 2024
71 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/improve-openapi-handling branch November 22, 2024 10:36
@nickvergessen
Copy link
Member Author

/backport ad5f9a5 15410d5 ff438bc to stable30

@backportbot backportbot bot mentioned this pull request Nov 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@miaulalala miaulalala miaulalala approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @miaulalala @provokateurin