Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid failures with link column database values from previous versions #779

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Avoid failures with link column database values from previous versions #779

merged 3 commits into from
Jan 18, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 18, 2024 •
edited
Loading

Fix #777

  • fix(link): Properly sanizite and map database values to what we expect it to be
  • fix: Avoid failing on empty strings for URL values

@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Jan 18, 2024
@juliusknorr juliusknorr changed the title fix/777 Avoid failures with link column database values from previous versions Jan 18, 2024
datenangebot
datenangebot approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@datenangebot datenangebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@juliusknorr
Copy link
Member Author

Pushed a unit test as well to cover all cases that might occur

@juliusknorr
Copy link
Member Author

/backport to stable0.6

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jan 18, 2024
@juliusknorr
fix(link): Properly sanizite and map database values to what we expec…
9df1541 
…t it to be

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Avoid failing on empty strings for URL values
852df21 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
tests: Cover link business logic for parsing with tests
612c437 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr merged commit 36ae10d into main Jan 18, 2024
43 checks passed
@juliusknorr juliusknorr deleted the fix/777 branch January 18, 2024 16:05
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 18, 2024
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Jan 18, 2024
@juliusknorr juliusknorr mentioned this pull request Jan 23, 2024
Closed
@MI-KY MI-KY mentioned this pull request Sep 28, 2024
Closed
@blizzz blizzz mentioned this pull request Nov 7, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datenangebot datenangebot datenangebot approved these changes

@enjeck enjeck Awaiting requested review from enjeck enjeck is a code owner

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating rows removes the github url column value
2 participants
@juliusknorr @datenangebot