Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint): Fix linting javascript files, also lint typescript files #6725

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Dec 2, 2024

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

mejo- added 2 commits December 2, 2024 16:26
Required to import all Nextcloud eslint rules, not only the typescript
ones.

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- added tests If you write them we ♥ you 3. to review labels Dec 2, 2024
@mejo- mejo- self-assigned this Dec 2, 2024
@mejo- mejo- requested a review from max-nextcloud as a code owner December 2, 2024 15:53
@mejo-
Copy link
Member Author

mejo- commented Dec 2, 2024

/backport to stable30

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/lint_js_and_ts branch from 0e8a113 to b26e0d9 Compare December 2, 2024 16:17
@mejo- mejo- merged commit 881b852 into main Dec 2, 2024
60 of 62 checks passed
@mejo- mejo- deleted the fix/lint_js_and_ts branch December 2, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review tests If you write them we ♥ you
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

2 participants