Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXstress contribution: stress-strain analysis #1039

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

NXstress contribution: stress-strain analysis #1039

wants to merge 25 commits into from

Conversation

woutdenolf
Copy link
Contributor

@woutdenolf woutdenolf commented Mar 24, 2022 •
edited
Loading

Application definition for stress-strain analysis as defined by the EASI-STRESS consortium.

NXstress HTML documenation:

https://hdf5.gitlab-pages.esrf.fr/nexus/nxstress_examples/classes/contributed_definitions/NXstress.html#nxstress

A short summary of the definition

entry@NXentry
    peaks@NXreflections  -->  serves as input for stress-strain calculations
    fit@NXprocess  -->  diagnostics of how `peaks` was generated
        peak_parameters@NXdata
        background_parameters@NXdata
        DIFFRACTOGRAM@NXdata
    instrument$NXinstrument  -->  meanly for geometry
        source@NXsource
        DETECTOR@NXdetector
        beam_intensity_profile@NXcollection
    sample_description$NXsample  -->  meanly for geometry
        gauge_volume@NXcollection
    notes@Nxnote  -->  free

Some examples:

@woutdenolf woutdenolf marked this pull request as ready for review March 24, 2022 16:46
@woutdenolf woutdenolf changed the title contribution for stress-strain analysis WIP: contribution for stress-strain analysis Mar 24, 2022
@woutdenolf woutdenolf marked this pull request as draft March 24, 2022 16:50
@woutdenolf woutdenolf added definitions contributions Add or modify a contributed definition labels Mar 24, 2022
@woutdenolf woutdenolf force-pushed the contrib_stress_strain branch 6 times, most recently from 0f4148c to b76c745 Compare March 26, 2022 17:47
@woutdenolf woutdenolf force-pushed the contrib_stress_strain branch 2 times, most recently from b217e8b to d9b00a5 Compare April 8, 2022 17:11
@woutdenolf woutdenolf force-pushed the contrib_stress_strain branch 8 times, most recently from 4277c3a to 2716c10 Compare April 27, 2022 12:48
@prjemian prjemian added this to the NXDL 2022.06 milestone Jun 14, 2022
@prjemian prjemian modified the milestones: NXDL 2022.06, NXDL 2023.06 Jun 24, 2022
@woutdenolf woutdenolf force-pushed the contrib_stress_strain branch 3 times, most recently from 8d6398d to 725e93f Compare June 30, 2022 22:01
@woutdenolf
Copy link
Contributor Author

  • rename diffraction_type to processing_type and add formulae
  • use enumerations when appropriate
  • rebase

@woutdenolf
Copy link
Contributor Author

  • fix PDF building (the Å symbol now works for HTML but is bank for PDF, no idea how to fix it, at least it does not break the build anymore)
  • energy/wavelength is now specified in NXbeam, not NXsource
  • update docs for NXnote for calibration

phyy-nx
phyy-nx reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@phyy-nx phyy-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick scan before the Telco

contributed_definitions/NXstress.nxdl.xml Outdated Show resolved Hide resolved
contributed_definitions/NXstress.nxdl.xml
</field>
<group type="NXtransformations" minOccurs="0">
<doc>
This is the recommended location for detector goniometer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these experiments include goniometers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They might. @aapaecklar can provide details.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear all, for the moment we only consider cradles for the eventual sin2psi method (1 ax rotation only)

@woutdenolf woutdenolf requested a review from a team May 15, 2024 15:34
@prjemian
Copy link
Contributor

NXparameters should be used in many places where NXdata is used. NXdata is intended to describe how to plot data.

@prjemian prjemian mentioned this pull request May 15, 2024
Open
woutdenolf and others added 2 commits May 15, 2024 17:56
@phyy-nx
Copy link
Contributor

phyy-nx commented May 15, 2024

Comments from Telco:

  • Consider NXparameters for peak_parameters
  • Consider in general NXparameters instead of NXcollections, because NXcollections by definition is not validated

@woutdenolf
Copy link
Contributor Author

woutdenolf commented May 15, 2024 •
edited
Loading

Changes applied as response to Telco discussion:

  • use NXparameters instead of NXdata and NXcollection, except for the DIFFRACTOGRAM group(s) which plot the powder diffractogram fit(s) and therefore NXdata is appropriate
  • added missing peak_parameter fields (center and _errors fields)

@aapaecklar
Copy link

aapaecklar commented Jun 21, 2024 •
edited
Loading

Do we have any updates here? Who was assigned to review NXstress?

@phyy-nx
Copy link
Contributor

phyy-nx commented Jun 26, 2024 •
edited
Loading

We will review this today in our telco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phyy-nx phyy-nx phyy-nx left review comments

@s-cabeza s-cabeza s-cabeza left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
code camp contributions Add or modify a contributed definition definitions
Projects
None yet
Milestone
later
Development

Successfully merging this pull request may close these issues.
5 participants
@woutdenolf @phyy-nx @prjemian @aapaecklar @s-cabeza