Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html artifact for easy documentation checking of pull requests #1041

Closed
wants to merge 1 commit into from
Closed

html artifact for easy documentation checking of pull requests #1041

wants to merge 1 commit into from

Conversation

woutdenolf
Copy link
Contributor

@woutdenolf woutdenolf commented Mar 24, 2022 •
edited
Loading

Closes #1280

Keep the HTML artifacts for HTML checking by reviewers of pull requests.

Limitations of this approach:

  • you don't have a link that lands you on the docs of the PR, you can only download the docs and view them locally
  • the download links are rather hidden
  • there is a time limit on the artifacts (I current took 30 days)

image

@woutdenolf woutdenolf added the workflows Continuous integration and deployment label Mar 25, 2022
@prjemian prjemian added this to the NXDL 2022.06 milestone Jun 14, 2022
@prjemian prjemian modified the milestones: NXDL 2022.06, NXDL 2023.06 Jun 24, 2022
@woutdenolf woutdenolf marked this pull request as ready for review June 16, 2023 12:07
@woutdenolf woutdenolf force-pushed the html_ci_artifacts branch 4 times, most recently from 0b3003a to c5f6ae7 Compare June 16, 2023 15:02
@woutdenolf woutdenolf mentioned this pull request Jun 16, 2023
Open
@woutdenolf woutdenolf mentioned this pull request Jun 23, 2023
Merged
@woutdenolf
Copy link
Contributor Author

Done by #1300 for HTML.

@woutdenolf woutdenolf closed this Nov 21, 2023
@PeterC-DLS PeterC-DLS modified the milestones: NXDL 2023.06, NXDL 2023.10 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code camp workflows Continuous integration and deployment
Projects
None yet
Milestone
NXDL 2023.10
Development

Successfully merging this pull request may close these issues.

HTML artifacts for reviewers
3 participants
@woutdenolf @PeterC-DLS @prjemian