Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload artifact #1300

Merged
merged 9 commits into from
Jun 26, 2023
Merged

Upload artifact #1300

merged 9 commits into from
Jun 26, 2023

Conversation

PeterC-DLS
Copy link
Contributor

@PeterC-DLS PeterC-DLS commented Jun 23, 2023

This allows html and pdf versions of the documentation to be checked. Maybe does some of #1280 and could help debug #1299

@PeterC-DLS PeterC-DLS requested review from RussBerg and a team June 23, 2023 17:35
@PeterC-DLS
Copy link
Contributor Author

See the artifacts available in https://github.com/nexusformat/definitions/actions/runs/5358923202

@woutdenolf
Copy link
Contributor

See #1041

@woutdenolf
Copy link
Contributor

As I pointed out in #1280 (comment) it is not good enough imo.

@prjemian
Copy link
Contributor

Once I found a CI process that actually had such artefacts, it was straightforward for me to download the one I wanted (html), extract it to a local directory and view the content. This was easier than maintaining a build system for the documentation, then pulling and building the branch.

While it may not yet pass the one-click to view test, it's a big improvement over the old way.

@PeterC-DLS - Do you see improvements which could be implemented in the near future?

@woutdenolf
Copy link
Contributor

Sure, it is better than nothing. Feel free to merge it.

@prjemian
Copy link
Contributor

@PeterC-DLS - Do you see improvements which could be implemented in the near future?

My mistake. This should have been directed to @woutdenolf, who said:

it is not good enough imo.

And he responded.

Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@woutdenolf
Copy link
Contributor

woutdenolf commented Jun 24, 2023

I listed some possible improvements here: #1280 (comment)

We can host MR builds on github or readthedocs. We just need to make sure a google search does not find any of these.

@PeterC-DLS PeterC-DLS force-pushed the upload-artifact branch 2 times, most recently from 2de5433 to ed7d176 Compare June 26, 2023 14:45
Copy link
Contributor

@RussBerg RussBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeterC-DLS
Copy link
Contributor Author

@RussBerg new contributers info now live!

@PeterC-DLS PeterC-DLS merged commit d669ffb into main Jun 26, 2023
8 checks passed
@PeterC-DLS PeterC-DLS deleted the upload-artifact branch June 26, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants