-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload artifact #1300
Upload artifact #1300
Conversation
See the artifacts available in https://github.com/nexusformat/definitions/actions/runs/5358923202 |
See #1041 |
As I pointed out in #1280 (comment) it is not good enough imo. |
Once I found a CI process that actually had such artefacts, it was straightforward for me to download the one I wanted (html), extract it to a local directory and view the content. This was easier than maintaining a build system for the documentation, then pulling and building the branch. While it may not yet pass the one-click to view test, it's a big improvement over the old way. @PeterC-DLS - Do you see improvements which could be implemented in the near future? |
Sure, it is better than nothing. Feel free to merge it. |
My mistake. This should have been directed to @woutdenolf, who said:
And he responded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I listed some possible improvements here: #1280 (comment) We can host MR builds on github or readthedocs. We just need to make sure a google search does not find any of these. |
2de5433
to
ed7d176
Compare
ed7d176
to
2299ede
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RussBerg new contributers info now live! |
This allows html and pdf versions of the documentation to be checked. Maybe does some of #1280 and could help debug #1299