-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to add contributor information to html pages (#1254) #1299
Conversation
@RussBerg Sorry, I won't have time to review in the next day or so. Perhaps someone else can review? I re-assigned to the NeXus developers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run the black
formatter
@PeterC-DLS are you familiar with the jenkins stuff to hazard a guess on how to pull the github access token from "secrets" and add it to the environment? |
Yes, I can adjust the workflow to populate the environment running the build with the token. Note, the CI is failing as there are files not formatted correctly. |
See this change definitions/.github/workflows/ci.yaml Lines 55 to 56 in 76d84d6
definitions/.github/workflows/ci.yaml Line 72 in 83498e7
|
Sorry, I clicked the wrong button! |
Does the CI GH token allow access to GH's REST API? If not, I could set an specific access token for this purpose |
yes the url that I am passing the token to in github.py uses the REST API endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ok I finally have all the code changes made to accomplish what was talked about,
The contributors are listed left to right most recent to oldest, mouse over gives name and date of last commit and clicking avatar takes you to that persons github profile.
Also added is the link to create a new github issue in the get help link.
A github access token is required to retrieve the contributor information from the github API and this token is passed in the environment variable GH_TOKEN. During the codecamp @mkuehbach sent me an example of how they do it in fairmat https://github.com/FAIRmat-NFDI/nexus-fairmat-proposal/blob/main/.github/workflows/update-proposal-webpage.yml
So it looks like what we need can be achieved in jenkins by wrapping the line:
definitions/jenkins_build
Line 30 in 2635a44
like this?
please @prjemian could you check me on this
closes #1254